fix(guidance): name precheck_file's argument as file_path, not path - #22
Merged
Merged
Conversation
AI_INSTRUCTIONS.md, the CLAUDE.md/AGENTS.md bridge, the MCP instructions= field and the README all showed the call as precheck_file(path). The tool's parameter is file_path, so agents that copied the shown call shape sent an argument the schema rejects. The new test reads the parameter name off the tool itself, so the guidance cannot drift from the signature again. Fixes riponcm#18
RTE404
force-pushed
the
fix/18-precheck-arg-name
branch
from
September 30, 2026 19:04
e076302 to
9d65540
Compare
Owner
|
Thanks Rohan, this is a clean fix, and reading the argument name off the tool's own signature is a nice touch so it can't drift again. Verified on my side: the new test fails on main and passes here, full suite green. I'll merge it in the next update, planned for this Sunday. |
riponcm
added a commit
that referenced
this pull request
Oct 2, 2026
…ool's real arguments PR #22 pinned precheck_file only, and the README still taught get_issue(id) where the parameter is issue_id. Read every registered tool's signature and check each call written in AI_INSTRUCTIONS, the bridge, the MCP instructions, the README, TUTORIAL and llms.txt. Fixes the two README get_issue(id) call shapes the sweep found. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
The agent guidance showed
precheck_file(path), but the tool's parameter isfile_path, so agents copying the call sent an argument the schema rejects. Corrected in:AI_INSTRUCTIONS.md(storage.py)commands/init.py)instructions=field (mcp_server.py)The README half of this landed on
mainin 7051f69, so I've rebased onto it and dropped my README edits. This PR is now just the three places agents read at runtime, plus the test.Test:
tests/test_agent_guidance.pyreads the parameter name fromprecheck_file's own signature and checks everyprecheck_file(...)call shown on all three surfaces uses it, so the guidance can't drift from the tool again. It fails onmain(3 failures, one per surface) and passes with this change.Verification (Windows 11, Python 3.12):
mainwithout this change (test_global_mcp.py×3,test_init_ux.py::test_print_mcp_config_single_project_still_pins_the_root), so they're pre-existing on Windows and unrelated.ruff check: no new findings. Each changed file reports the same findings as onmain.main; one commit.Note:
AI_INSTRUCTIONS.mdis only written when missing, so existing projects keep the old text until it is deleted andpjm initis re-run.