config: support optional references; fix auto saving - #146
Merged
Merged
Conversation
Contributor
|
我這邊驗證沒有問題,可以生成了。只是有個編譯error,可能跟編譯參數有關。把問號放LOG裏面就好了。 index 675ed19..873124a 100644
--- a/src/rime/config/config_compiler.cc
+++ b/src/rime/config/config_compiler.cc
@@ -361,7 +361,7 @@ static an<ConfigItem> ResolveReference(ConfigCompiler* compiler,
if (!resource->loaded) {
- (reference.optional ? LOG(WARNING) : LOG(ERROR))
+ LOG(reference.optional ? WARNING : ERROR)
<< "resource could not be loaded: " << reference.resource_id; |
Contributor
Author
|
嗯有空改改。我又想了想,可选加载的时候不需要报错。 |
Contributor
|
或者默認都改成可選加載。加個+、!之類的,表示必須要加載,報錯。 |
Member
|
我的意見是默認必須加載。 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #144)