Alerts slack integration UI - #4509
Merged
Merged
Conversation
Contributor
|
I'm seeing the Slack section, even though I haven't yet enabled the connector. If the connector hasn't been enabled, we should probably replace the section (form inputs) with a note. Something like: "Slack has not been configured for this project. Read the docs (link) to learn more." 
|
ericpgreen2
approved these changes
Apr 6, 2024
| export let title: string; | ||
| export let description: string = ""; | ||
| export let padding = "p-3"; | ||
| export let showEnabled = false; |
Contributor
There was a problem hiding this comment.
Name suggestion: showSectionToggle
| } from "./form-utils"; | ||
|
|
||
| export let formState: any; // svelte-forms-lib's FormState | ||
| export let formState: ReturnType<typeof createForm<AlertFormValues>>; |
Contributor
There was a problem hiding this comment.
Great to see this typing 👍
Collaborator
Author
|
Good catch about the slack showing up. There was a bug in how i used the signal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4410
Adds a section to add slack notifications if it is enabled.
Run
rill env set "connector.slack.bot_token" "xoxb-..." --project ...to enable slack connector.