Enable ListNotifierConnectors for Slack - #4505
Merged
Merged
Conversation
esevastyanov
reviewed
Apr 3, 2024
| } | ||
| } | ||
|
|
||
| // Connectors may be implicitly defined just by adding variables in the format "connector.<name>.<property>". |
Contributor
There was a problem hiding this comment.
Slack connector is defined even if bot token isn't there but only for webhooks
Contributor
Author
There was a problem hiding this comment.
Yeah the abstractions definitely get blurry with that kind of "anonymous" functionality. In this case, it's useful for the ListNotifierConnectors only to return connectors that have been configured somehow (with vars or by adding to rill.yaml). Will add a note in the PR about it.
esevastyanov
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListNotifierConnectors.ListNotifierConnectorsAPI does not yet return info about email connector.