Stop the musl build from overwriting the glibc build in releases - #2
Merged
Conversation
The upload artifact name was keyed on php version and architecture only, so adding the musl row gave the 8.3 glibc and 8.3 musl builds the same name. Both jobs reported success, the download step collapsed them into one, and ext-v0.0.4 shipped two binaries instead of three — the 8.3 glibc build was silently absent while every check stayed green. Include the libc in the artifact name, and assert each expected binary is present before publishing so a lost build fails the release instead of quietly narrowing platform coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-v0.0.4published only two of its three binaries. All three build jobs passed, but the artifact name omitted the libc, so the 8.3 glibc and 8.3 musl uploads collided underext-8.3-amd64and one replaced the other. The 8.3 glibc binary is missing from the release and nothing failed.Include the libc in the artifact name, and verify every expected binary exists before publishing, so losing a matrix build fails the release rather than quietly reducing platform coverage.
No agent code changes. After merge the tag needs re-cutting to produce a complete set.