Skip to content

Feat/machine type config - #100

Open
kwame-Owusu wants to merge 5 commits into
revett:mainfrom
kwame-Owusu:feat/machine-type-config
Open

Feat/machine type config#100
kwame-Owusu wants to merge 5 commits into
revett:mainfrom
kwame-Owusu:feat/machine-type-config

Conversation

@kwame-Owusu

@kwame-Owusu kwame-Owusu commented Jun 24, 2026

Copy link
Copy Markdown

Closes #95

Description

Use HOPS_MACHINE environment variable injected into commands instead of passing flag for targeting commands. this will help in the cases where we want to use the machine variable in other scripts or behaviours for hops.

Changes

remove the --machine flag in preference for set environment variable. this removes the options that were added to the apply and generate commands.

Tests

Results of tests based on three scenarios of the HOPS_MACHINE environment variable state

HOPS_MACHINE unset -> Fails: "HOPS_MACHINE environment variable is not set"
HOPS_MACHINE=shared -> Fails: "Machine cannot be 'shared' as it is reserved"
HOPS_MACHINE=work -> Generates Brewfile, Machine: work

P.S.

Added types to tsconfig because I wanted to navigate the codebase and write the code, and the patterns in the codebase are clear so it was quite easy to implement.
I've been using this cli tool for 2 weeks now, and i like it, just wanted to contribute to it 😄

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Confidence score: 5/5

  • In src/commands/generate.ts, the machine lookup error still tells users to use a removed --machine flag, which can send them down the wrong remediation path and slow down recovery from failures; update the message to reference HOPS_MACHINE before merging to keep guidance accurate.

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/generate.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for machine type in config

1 participant