Feat/machine type config - #100
Open
kwame-Owusu wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 5/5
- In
src/commands/generate.ts, the machine lookup error still tells users to use a removed--machineflag, which can send them down the wrong remediation path and slow down recovery from failures; update the message to referenceHOPS_MACHINEbefore merging to keep guidance accurate.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
Description
Use HOPS_MACHINE environment variable injected into commands instead of passing flag for targeting commands. this will help in the cases where we want to use the machine variable in other scripts or behaviours for hops.
Changes
remove the --machine flag in preference for set environment variable. this removes the options that were added to the apply and generate commands.
Tests
Results of tests based on three scenarios of the HOPS_MACHINE environment variable state
HOPS_MACHINE unset -> Fails: "HOPS_MACHINE environment variable is not set"
HOPS_MACHINE=shared -> Fails: "Machine cannot be 'shared' as it is reserved"
HOPS_MACHINE=work -> Generates Brewfile, Machine: work
P.S.
Added types to tsconfig because I wanted to navigate the codebase and write the code, and the patterns in the codebase are clear so it was quite easy to implement.
I've been using this cli tool for 2 weeks now, and i like it, just wanted to contribute to it 😄