Skip to content

Return 11247 migrate event jobs to sidekiq#8

Open
dmartingarcia wants to merge 8 commits intomasterfrom
RETURN-11247-migrate-event-jobs-to-sidekiq
Open

Return 11247 migrate event jobs to sidekiq#8
dmartingarcia wants to merge 8 commits intomasterfrom
RETURN-11247-migrate-event-jobs-to-sidekiq

Conversation

@dmartingarcia
Copy link
Contributor

@dmartingarcia dmartingarcia commented Jun 15, 2022

Ticket 🎫

🔗 Jira ticket

Context 📓

Switch away from ActiveJob and use Sidekiq API

Testing 🧪

Client applications PR's 📎

Best Practices

In order to achieve a consensus on PRs and improve our workflow, the team has decided to agree on best practices Check them out!

Here is a list of them:

  • Keep the PR as small as possible, dividing it into different PRs if possible
  • Commits are descriptive and show information on the ticket journey
  • Explain reasons behind changes that might not be obvious or seem complex

@dmartingarcia dmartingarcia marked this pull request as ready for review June 15, 2022 09:48
@dmartingarcia
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant