docs: README images and nav links broken on PyPI (relative paths not resolved) - #216
docs: README images and nav links broken on PyPI (relative paths not resolved)#216Elkero (YuuGR1337) wants to merge 1 commit into
Conversation
Review: close in favor of #214Thanks for picking this up, Elkero (@YuuGR1337). The one URL you changed is correct (verified Completeness check against issue #211Issue #211 lists three categories of broken renderings on PyPI: the logo image, the framework diagram image, and the nav links (Get started / Targets / CLI / Examples). It also notes the
After merging #216 the PyPI page would still 404 on every nav link and still fail to render the framework diagram, so AC #1 and AC #2 in issue #211 are not satisfied. Comparison vs #214Same approach (rewrite relative paths to absolute VerdictClose in favor of #214. No code-quality concerns here — the change is correct as far as it goes — but shipping only the logo fix would leave the bug effectively unfixed on PyPI and bake an incomplete state into the next immutable release. If #214 stalls, this PR would need to expand to cover the remaining 8 references before it can close #211. (Note: an automated audit of #214 is running in parallel; if it surfaces a blocker there, we'll revisit.) |
|
Closing in favor of #214, which covers the same PyPI README link/image fixes more comprehensively. Thanks for catching this! |
Fixes #211