Bump arrow to 56.1 and datafusion to 50 - #11248
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
bf84356 to
2b9604f
Compare
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
The issue I foresee with this is that dataplatform relies on lance which was just updated to datafusion 49. If we merge this PR then we will need those to both update to get a consistent build. |
03a1766 to
c97e75a
Compare
c97e75a to
67b867c
Compare
|
Arrow 56.2.0 is released: https://github.com/apache/arrow-rs/releases/tag/56.2.0
|
The bigger hold up was datafusion-python 50 which I released this morning, so now I can push lance to update |
|
PR for lance update that we need: lance-format/lance#4778 |
67b867c to
a80d8e4
Compare
|
I just did a rebase and resolved a bunch of issues. I'll take a look at CI tomorrow. |
a80d8e4 to
d91d4e2
Compare
| │ METADATA: │ | ||
| │ * entity_path: /this/that │ | ||
| │ * heap_size_bytes: 944 │ | ||
| │ * heap_size_bytes: 896 │ |
There was a problem hiding this comment.
This is not surprising with the arrow update
8acccde to
f78daa6
Compare
|
Hurray! CI is in the green. I am working on the other repo so we can upgrade these side by side. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/18527577409 |
f78daa6 to
a32c3d1
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/18537333513 |
a32c3d1 to
493173f
Compare
|
@grtlr Can you help me on this? I'm getting all kinds of image snapshot changes and I don't know how to dive in to see if there is a real problem or not. I wouldn't expect these arrow/datafusion changes to impact the viewer. Maybe we can pair on it tomorrow? |
| js-sys = "0.3.77" | ||
| jsonwebtoken = { version = "9.3", default-features = false } | ||
| lance = { version = "0.36.0", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) | ||
| lance = { version = "0.38.2", default-features = false } # When you update this, also update the list of features enabled for `datafusion` (~50 lines up) |
There was a problem hiding this comment.
Reminder to follow this instruction before merging!
b13ca9b to
5124237
Compare
5124237 to
fb1079b
Compare
The other side is not ready yet, and right now Redap `main` is broken. * Reverted: #11248 * The other side: https://github.com/rerun-io/dataplatform/pull/1859
Revival of #11248 which was reverted in #11712. * DNM: Blocked on sibling: https://github.com/rerun-io/dataplatform/pull/1859 --- ### Related * Currently blocking #11221. * Supersedes #11159. ### TODO * [x] Double check `.expect()`. (copied over from #11159) * [x] Pin `datafusion` to `50.0.0`? * [x] Finish https://github.com/rerun-io/dataplatform/pull/1859 * [x] `@rerun-bot full-check` ### Reviewing * Please expand files like `package_lock.json` (collapsed on GitHub) to see if everything makes sense. * For good measure, please `git diff` against #11159 too. --------- Co-authored-by: Jochen Görtler <me@jgoertler.com> Co-authored-by: Tim Saucer <timsaucer@gmail.com>
Related
oneofvalues inprotobuf-based MCAP files #11221.TODO
.expect(). (copied over from DataFusion 49 upgrade #11159)datafusionto50.0.0?Reviewing
package_lock.json(collapsed on GitHub) to see if everything makes sense.git diffagainst DataFusion 49 upgrade #11159 too.