Appveyor CI is failing

[jamessspanggg]

Appveyor CI is current failing in all PRs with the following lines:

Link to one of the Appveyor build for PR #1005: https://ci.appveyor.com/project/eugenepeh/reposense/builds/30213033

[jamessspanggg]

May be due to AppVeyor's recent Windows image update: https://www.appveyor.com/updates/

[0blivious]

I feel the failed test is actually the 2 below. However, I am unable to reproduce them locally.

[fzdy1914]

@reposense/devs Please help with this issue and try to get it solved quickly.

[fzdy1914]

[jamessspanggg]

With the update, using git checkout to a branch with illegal window file names will incur an exception...

[jinyao-lee]

I actually think that these two test cases are no longer relevant and can be removed.

Reason: in windows, repos and branches that are to be analyzed would have been checked for illegal filenames via gitlstree (from the bare clone) before they are checked out from the bare repo to the actual ones

[jinyao-lee]

Investigating further, the test cases worked on Git 2.23 (my previous setup before updating) but not on 2.25.

Current version is 2.25 and that's the version that the AppVeyor is now on with the latest update

git-for-windows/git#2440

[0blivious]

As updated from Git v2.24, Git for windows would print error for illegal file name and prevent it from adding into index. As in our test cases we run the command git checkout someInvalidName, an exception is expected to be thrown, and since we do not catch it, the test fail. An work around in local machine is to disable core.protectNTFS.

The doc for protectNTFS can be found here. It is set to be true for windows and false for other systems. https://git-scm.com/docs/git-config

Since even the git command will fail on windows, maybe we should remove the 2 tests, or we test if the correct exception is to be thrown

[yong24s]

Let's remove the two outdated tests.

Well done in the prompt investigation and thank you for the effort 👍.