Other Cucumber plugins are not executing if ReportPortal server is down

[fslevoaca-ionos]

Describe the bug
Other Cucumber plugins are not executing if ReportPortal server is down

Steps to Reproduce
Steps to reproduce the behavior:

1. Configure ReportPortal plugin along with Cucumber JSON plugin

        <profile>
            <id>report-portal</id>
            <properties>
                <cucumber.plugin>
                    <!-- @formatter:off -->
                    json:target/cucumber-report/report.json,com.epam.reportportal.cucumber.ScenarioReporter
                    <!-- @formatter:on -->
                </cucumber.plugin>
            </properties>
            <dependencies>
                <dependency>
                    <groupId>com.epam.reportportal</groupId>
                    <artifactId>agent-java-cucumber7</artifactId>
                    <version>${report.portal.cucumber.agent.version}</version>
                    <scope>test</scope>
                </dependency>
            </dependencies>

2. Shut down ReportPortal server.
3. Run tests

Expected behavior
JSON Cucumber plugin should generate the report inside target/cucumber-report/report.json even if the ReportPortal server is down.

Actual behavior
target/cucumber-report/report.json is empty because the ReportPortal client fails to connect to server.

This is because both ReportPortal and JSON Cucumber plugins are using the same event bus, hence if Cucumber ReportPortal plugin has uncaught errors, Cucumber's event bus stops propagating that event to the remaining handlers.

Solution is to make Cucumber ReportPortal plugin com.epam.reportportal.cucumber.ScenarioReporter fault tolerant.

[HardNorth]

@fslevoaca-ionos Yes, it must not throw any exceptions. Did you have any chance to catch the stack trace?

[fslevoaca-ionos]

@HardNorth Sure
This is the stacktrace

Exception in thread "rp-io-16" io.reactivex.exceptions.UndeliverableException: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling | java.net.ConnectException: Failed to connect to qareportportal.ops.server.lan/10.77.194.3:443
        at io.reactivex.plugins.RxJavaPlugins.onError(RxJavaPlugins.java:367)
        at io.reactivex.internal.operators.maybe.MaybeZipArray$ZipCoordinator.innerError(MaybeZipArray.java:138)
        at io.reactivex.internal.operators.maybe.MaybeZipArray$ZipMaybeObserver.onError(MaybeZipArray.java:181)
        at io.reactivex.internal.operators.maybe.MaybeSubscribeOn$SubscribeOnMaybeObserver.onError(MaybeSubscribeOn.java:96)
        at io.reactivex.internal.operators.maybe.MaybeCache.subscribeActual(MaybeCache.java:62)
        at io.reactivex.Maybe.subscribe(Maybe.java:4290)
        at io.reactivex.internal.operators.maybe.MaybeSubscribeOn$SubscribeTask.run(MaybeSubscribeOn.java:54)
        at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:38)
        at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:26)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.net.ConnectException: Failed to connect to qareportportal.ops.server.lan/10.77.194.3:443
        at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:297)
        at okhttp3.internal.connection.RealConnection.connect(RealConnection.kt:207)
        at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.kt:226)
        at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.kt:106)
        at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.kt:74)
        at okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:255)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at com.epam.reportportal.service.PathParamInterceptor.intercept(PathParamInterceptor.java:85)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at com.epam.reportportal.service.BearerAuthInterceptor.intercept(BearerAuthInterceptor.java:41)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
        at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
        at okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)
        at retrofit2.OkHttpCall.execute(OkHttpCall.java:207)
        at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(CallExecuteObservable.java:46)
        at io.reactivex.Observable.subscribe(Observable.java:12284)
        at retrofit2.adapter.rxjava2.BodyObservable.subscribeActual(BodyObservable.java:35)
        at io.reactivex.Observable.subscribe(Observable.java:12284)
        at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
        ... 6 more
Caused by: java.net.ConnectException: Connection refused
        at java.base/sun.nio.ch.Net.pollConnect(Native Method)
        at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:684)
        at java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:554)
        at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:602)
        at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
        at java.base/java.net.Socket.connect(Socket.java:633)
        at okhttp3.internal.platform.Platform.connectSocket(Platform.kt:128)
        at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:295)
        ... 31 more

[fslevoaca-ionos]

@HardNorth Thanks !
Can you please also release agent-java-cucumberx since these are using client-java ? And via these plugins this issue was discovered.
Cheers !

[HardNorth]

@fslevoaca-ionos Released