Minor refactor based on comments from previous PR#134
Merged
Conversation
replbot
added
boop
|
Good work, this PRs short and easy to review! Promoting to |
alex-4ed5ec60d
approved these changes
Jul 5, 2022
poorvapotnis
added a commit
that referenced
this pull request
Apr 17, 2026
Fixes Dependabot alert #134 (arbitrary code execution in protobufjs). protobufjs is pulled in transitively via @replit/protocol and versions <7.5.5 allow attackers who can control protobuf definitions to execute arbitrary JS during object decoding. The @replit/protocol package declares protobufjs "^7.2.5" so no downstream version constraints change; only the lockfile is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Merged #132 too quickly without addressing reviewer comments
What changed
Minor refactor and spell correction for clarity
Test plan
Tests pass