Repository navigation
Release v0.33.1: Windows-safe anonymize test and complete v0.33.0 docs - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to v0.33.0, so the published package and master's CI match what v0.33.0 shipped:
fixture --anonymizetest checked that the report'ssource_dirends in/project. On Windows the anonymized path correctly ends in\project, so the platform smoke onwindows-latestfailed on master while the code behaved as intended. The assertion now accepts either separator.docs/command-reference.zh-CN.mdgains thediff --since-writeandfixture --anonymize/--checkforms the English reference already lists.docs/command-reference.jsonin the 0.33.0 package still said 0.32.0, because it was regenerated before the version bump; it now reports the package version.Evidence
C:\…\projectand/…/project.npm run build,npm test(1,477 tests, 1,474 pass, 0 fail, 3 skipped),npm run lint,python -m unittest discover -s python/tests, and the packed-tarball smoke forcapcut-cli-0.33.1.tgzpass; regenerating the command docs gives no further change.Door
Two-way: one test assertion and documentation, plus the patch version; reverted by reverting the three commits.
Blast radius
test/fixture-anonymize.test.mjs,README.md,docs/command-reference.zh-CN.md,docs/command-reference.json,CHANGELOG.md,package.json,package-lock.json. Base:54991a5c897db9b5d39b688cd1c40655ee7bb326(master after v0.33.0). No other pull request touches these files except #167, which changes only dev-dependency lines in the package files.