Skip to content

fix: validate denoise field in isValidRecipe (#1661) - #1665

Merged
magic-peach merged 1 commit into
reframe-oss:mainfrom
aaniya22:fix/1661-denoise-validation-isvalidrecipe
Aug 14, 2026
Merged

magic-peach merged 1 commit into
reframe-oss:mainfrom
aaniya22:fix/1661-denoise-validation-isvalidrecipe

Conversation

@aaniya22

@aaniya22 aaniya22 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Closes #1661

Description

isValidRecipe in src/lib/types.ts was missing validation for the denoise field on EditRecipe. This meant malformed or missing denoise values could pass validation and reach downstream code expecting a boolean. Added a typeof v.denoise !== "boolean" check, following the same pattern as the existing stabilization check.

Related Issue

Fixes #1661

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: aaniya22
  • Contribution level (Beginner/Intermediate/Advanced):

Screen Recording

Recording / Loom link:

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors) — the only errors present are pre-existing, in a generated build file (out/_next/static/media/ffmpeg.worker.*.ts), unrelated to this change
  • New interactive elements have aria-label / accessible names
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

@aaniya22 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @aaniya22!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @aaniya22

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Aug 6, 2026
@magic-peach
magic-peach merged commit 71d0d38 into reframe-oss:main Aug 14, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts needs-fixes PR has issues that need to be fixed type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing denoise validation in isValidRecipe

2 participants