Skip to content

[BUG] README's Keyboard Shortcuts table lists only 4 of the 8 shortcuts that actually exist #1779

Open

Description

@magic-peach

Bug description
src/hooks/useKeyboardShortcuts.ts implements 8 distinct shortcuts: Ctrl/Cmd+Shift+E (export), M (mute), R (reset), Escape (cancel), 1-9 (preset switch), ? (toggle shortcuts panel), I (set trim in-point), O (set trim out-point). README.md's table (lines 93-100) lists only Ctrl+Enter/Export, Space, M, Escape — and "Ctrl+Enter" doesn't even match the actual code (which uses Ctrl/Cmd+Shift+E, not Enter).

Steps to reproduce
Compare README.md:93-100 against useKeyboardShortcuts.ts:44-87.

Expected behavior
Table should list all 8 real shortcuts with correct key combinations.

Actual behavior
Half the shortcuts are undocumented, and the one export shortcut listed is described incorrectly (Space for play/pause isn't even in the useKeyboardShortcuts hook either — worth double-checking where that one is actually wired before finalizing the fix).

Distinct from #1423, #1118, and #91, which are about the in-app Keyboard Shortcuts panel/? key being broken — this issue is purely about the README's own markdown table being incomplete/inaccurate, independent of whether the in-app panel works.

Activity

  1. added
    bugSomething isn't working correctly
    gssoc'26GirlScript Summer of Code 2026
    on Sep 15, 2026
  2. github-actions commented on Sep 15, 2026

    @github-actions
    Contributor

    👋 Thanks for opening an issue, @magic-peach!

    Our maintainers will review this shortly 🚀

    Before you start working

    • 📖 Read the CONTRIBUTING.md guide
    • 💬 Wait for a maintainer to assign you the issue before starting work
    • 🔍 Search for existing issues to avoid duplicates

    For GSSoC'26 contributors

    If you're contributing under GirlScript Summer of Code 2026, please mention it in your comment when requesting assignment:

    "I'd like to work on this — contributing under GSSoC'26"

    Architecture notes

    Reframe is a static Next.js app with output: "export". Key points:

    • All video processing uses FFmpeg.wasm (client-side, no server)
    • headers() in next.config.ts won't work — use vercel.json instead
    • not-found.tsx requires public/404.html + vercel.json routes config

    Happy contributing! ⭐ Star the repo if you find it useful!

  3. github-actions commented on Sep 15, 2026

    @github-actions
    Contributor

    Claude encountered an error —— View job


    I'll analyze this and get back to you.

  4. pranav28042007-boop commented on Sep 21, 2026

    @pranav28042007-boop

    Hi, I'd like to work on this issue. I've reviewed the existing keyboard shortcut implementation and understand that the README needs to be updated to accurately document the shortcuts currently implemented in the project.

    I'd like to contribute this under GSSoC'26. If the issue is still available, could you please assign it to me? Thank you!

  5. godlykmathews commented on Oct 1, 2026

    @godlykmathews

    Hi, I would like to contribute to this issue, is it still available?

  6. github-actions commented on Nov 1, 2026

    @github-actions
    Contributor

    👋 This issue has been inactive for 30 days. It will be automatically closed in 14 days if there's no further activity.

    If you're still interested in working on this, please leave a comment!
    For GSSoC'26 contributors: make sure to keep your assigned issues active.

    ⭐ Star Reframe if you find it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working correctlydocumentationDocumentation improvementgssoc'26GirlScript Summer of Code 2026level:beginnerBeginner level - 20 ptsneeds investigationNeeds more investigation before work beginstype:bugBug fixtype:docsDocumentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions