Warnings in extension development

[Eskibear]

Not a blocking issue. Just some annoying warning messages in debug console if I have xml extension installed.

[redhat.vscode-xml] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[xml]', provide the URI of a resource or 'null' for any resource.
[redhat.vscode-xml] Accessing a window scoped configuration for a resource is not expected. To associate 'xml.completion.autoCloseTags' to a resource, define its scope to 'resource' in configuration contributions in 'package.json'.

The first one:

vscode-xml/src/extension.ts

Line 128 in 32b586c

let closeBrackets = configXML.get("[xml]")["editor.autoClosingBrackets"];

let configXML = workspace.getConfiguration(undefined, null), ConfigXML.get("[xml]") should work.

The second one:

vscode-xml/src/extension.ts

Line 86 in 32b586c

disposable = activateTagClosing(tagRequestor, { xml: true, xsl: true }, 'xml.completion.autoCloseTags');

vscode-xml/src/tagClosing.ts

Line 32 in 407cd65

if (!workspace.getConfiguration(void 0, document.uri).get<boolean>(configName)) {

vscode-xml/package.json

Lines 152 to 156 in 32b586c

	"xml.completion.autoCloseTags": {
	"type": "boolean",
	"default": true,
	"description": "Enable/disable autoclosing of XML tags. \n\nIMPORTANT: Turn off editor.autoClosingTags for this to work",
	"scope": "window"

[fbricon]

@Eskibear do you think you could provide a PR?

[Eskibear]

It's a one-line change for the first one.

For the second one, the statement is written in such way because html.autoClosingTags is a resource scoped conf. I notice all configs are window scoped in this extension, that means it's not supported to use different configs for each workspace folder (in a multi-root workspace). I've no idea how largely you will re-used this function, so I think either of the following works.

• Simply remove "document.uri" when getting the config. (one-line change, ok for now but blocks multi-root workspace support)
• Change the config to resource scoped. (suggest to be within multi-root workspace support)

[datho7561]

@Eskibear I worked on a quick PR to address these warnings. I used the method you described to fix the first warning to address both the warnings, since LemMinX doesn't support multi-root workspaces yet. Does this solution make sense?

[Eskibear]

@datho7561 commented, you shall refer to vscode's API spec.

[datho7561]

@Eskibear, Thanks for your help!