Ending empty line is always deleted

[davidavetyan]

After formatting any XML document, the empty line at the end is always removed.
This happens even if the following extension settings are set:

xml.format.preserveAttributeLineBreaks: true
xml.format.preservedNewlines: 2

Either the formatter should respect the xml.format.preservedNewlines value when formatting the ending lines, or a new setting should be added to control this behavior.

[pbodnar]

I've just run into this problem. From my tests, it seems like the formatter honors what is being set in the files.insertFinalNewline VS Code setting. If this is set to true, the formatter no longer removes the ending EOL - so that is one way of how to workaround the problem.

Yet, I believe this really is an error and the formatter should rather leave the end of the file as-is. And that there is probably no need to introduce any setting for this, or is it?

[angelozerr]

Of I remember we use the settings from vscode like @pbodnar said

[gk-bbai]

It should prioritize the insert_final_newline value in .editorconfig over the VS Code default setting.

If a user uses .editorconfig then they most likely won't bother setting files.insertFinalNewline.