Synchronize bundles on demand#2729
Merged
Merged
Conversation
snjeza
approved these changes
Oct 10, 2022
Collaborator
Author
|
This PR should also help the case that |
jdneo
force-pushed
the
cs/install-bundle
branch
from
4ce28b9 to
460df1a
Compare
- Allow server to ask bundles to synchronize before ready. - When new bundle is detected, instead of asking user to reload window, we will try to let JDT.LS hot load the bundle first. Signed-off-by: sheche <sheche@microsoft.com>
jdneo
force-pushed
the
cs/install-bundle
branch
from
460df1a to
15aab66
Compare
rgrunber
approved these changes
Oct 12, 2022
rgrunber
left a comment
rgrunber
left a comment
Member
There was a problem hiding this comment.
Works for me. Feel free to merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires eclipse-jdtls/eclipse.jdt.ls#2267
How to test
bundle.mp4
Signed-off-by: sheche sheche@microsoft.com