Skip to content

Update postgres setup guide - #61

Merged
rm3l merged 4 commits into
redhat-developer:mainfrom
zeshanziya:patch-2
Jul 15, 2025
Merged

rm3l merged 4 commits into
redhat-developer:mainfrom
zeshanziya:patch-2

Conversation

@zeshanziya

@zeshanziya zeshanziya commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor

Description

Which issue(s) does this PR fix or relate to

  • Fixes #issue_number

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Summary by Sourcery

Documentation:

  • Add a new step showing sample Postgres configuration in app-config.local.yaml, including client, pluginDivisionMode, and connection settings

@sourcery-ai

sourcery-ai Bot commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR enhances the PostgreSQL setup guide by inserting a new step illustrating how to configure Postgres settings in app-config.local.yaml with an example YAML snippet.

File-Level Changes

Change Details Files
Add Postgres configuration instructions to the guide
  • Insert a new step 5 into the setup sequence
  • Include a YAML code block showing database.client, pluginDivisionMode, and connection settings
additional-config-guides/postgresql-guide.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zeshanziya - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread additional-config-guides/postgresql-guide.md Outdated
Comment thread additional-config-guides/postgresql-guide.md Outdated
@zeshanziya

Copy link
Copy Markdown
Contributor Author

Thank you @rm3l. I have worked on suggestions. Please review.

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zeshanziya !!

/lgtm

Comment thread additional-config-guides/postgresql-guide.md Outdated
@rm3l

rm3l commented Jul 15, 2025

Copy link
Copy Markdown
Member

/hold

@rm3l

rm3l commented Jul 15, 2025

Copy link
Copy Markdown
Member

/cherry-pick release-1.7

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rm3l: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: Armel Soro <armel@rm3l.org>
@openshift-ci openshift-ci Bot removed the lgtm label Jul 15, 2025

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 15, 2025
@rm3l
rm3l merged commit 73ee213 into redhat-developer:main Jul 15, 2025
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rm3l: new pull request created: #66

Details

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants