Repository navigation
feat: Add support to user-specific overrides for catalog users and components - #47
Merged
rm3l merged 32 commits intoJun 24, 2025
Merged
Conversation
Member
Author
|
cc/ @rm3l for review, please |
Member
|
/cc |
rm3l
requested changes
Jun 6, 2025
rm3l
requested changes
Jun 10, 2025
Fortune-Ndlovu
force-pushed
the
RHIDP-4263-users-yaml-override
branch
from
June 16, 2025 14:19
6973631 to
f80fa06
Compare
Member
|
@Fortune-Ndlovu Could you please rebase your branch and fix the conflicts? |
Fortune-Ndlovu
force-pushed
the
RHIDP-4263-users-yaml-override
branch
2 times, most recently
from
June 17, 2025 11:22
d08d145 to
03fa772
Compare
Fortune-Ndlovu
force-pushed
the
RHIDP-4263-users-yaml-override
branch
from
June 17, 2025 11:25
03fa772 to
e6d4f25
Compare
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Member
Author
|
@rm3l I have rebased and fixed conflicts |
rm3l
requested changes
Jun 17, 2025
Member
Author
|
Thanks @rm3l, I've made the following changes to align with the convention you recommended:
cp configs/catalog-entities/users.override.example.yaml configs/catalog-entities/users.override.yaml
cp configs/catalog-entities/components.override.example.yaml configs/catalog-entities/components.override.yaml
USERS_OVERRIDE="/opt/app-root/src/configs/catalog-entities/users.override.example.yaml"
COMPONENTS_OVERRIDE="/opt/app-root/src/configs/catalog-entities/components.override.example.yaml"This setup ensures that example override files are tracked in Git, while actual user configs remain local and Git-ignored. It also aligns with how dynamic plugin overrides are handled |
rm3l
reviewed
Jun 17, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Member
Author
|
Thanks @rm3l for the thorough review! |
rm3l
reviewed
Jun 19, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
rm3l
requested changes
Jun 20, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
…rride, then append your custom ones Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
… any targeting users.yaml or components.yaml, and append override entries for those two only. Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
rm3l
reviewed
Jun 23, 2025
rm3l
reviewed
Jun 23, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
rm3l
reviewed
Jun 24, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Member
Author
|
@rm3l lgtm |
rm3l
reviewed
Jun 24, 2025
1 of 3 tasks
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
wait-for-plugins-and-start.shscript now simplifies startup by:app-config.yamltogenerated/app-config.patched.yamltarget:paths forusers.yamlandcomponents.yamlif corresponding override files existWhich issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer