You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[release-1.9] chore: pin RHDH image version to 1.9.8 - #319
I have verified this PR targets the correct branch (see branching strategy)
Description
Which issue(s) does this PR fix or relate to
Fixes #issue_number
PR acceptance criteria
Tests updated and passing
Documentation updated
Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.
How to test changes / Special notes to the reviewer
• Pins RHDH runtime and plugin installer defaults to patch release 1.9.8.
• Aligns the plugin catalog index with RHDH 1.9.8 for reproducible environments.
Diagram
graph TD
C["Compose Config"] -->|"RHDH 1.9.8"| I["Plugin Installer"] -->|"prepared plugins"| R["RHDH Runtime"]
E["Environment Defaults"] -->|"selects 1.9.8"| P["Catalog Index"] -->|"plugin metadata"| I
C -->|"RHDH 1.9.8"| R
Loading
High-Level Assessment
Explicit patch-level pins are appropriate for a supported release branch because they keep the runtime, installer, and catalog deterministic and compatible. Floating 1.9 tags were considered but would allow unreviewed patch changes to alter local environments.
Files changed (2) +3 / -3
Other (2) +3 / -3
compose.yamlPin both RHDH services to image 1.9.8+2/-2
Pin both RHDH services to image 1.9.8
• Changes the default image for the RHDH runtime and dynamic plugin installer from the floating 1.9 tag to 1.9.8. Existing RHDH_IMAGE overrides remain supported.
1. Users can still select the old floating image 🐞 Bug⚙ Maintainability
Description
The Compose default now uses quay.io/rhdh-community/rhdh:1.9.8, but the documented override and
container-image guide still tell users to use quay.io/rhdh-community/rhdh:1.9. Following those
instructions explicitly selects the unpinned image and undermines the release branch's version pin.
ⓘ Recommendations generated based on similar findings in past PRs
Evidence
The changed Compose default is quay.io/rhdh-community/rhdh:1.9.8, while the repository's
user-facing override example and image guide still reference the old floating :1.9 tag. This makes
the documented explicit configuration inconsistent with the pinned release configuration.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The Compose default was pinned to RHDH 1.9.8, but the commented environment override and container-image guide still reference the floating `:1.9` tag. Users following those instructions can explicitly run a different, unpinned image than the release default.
## Fix Focus Areas
- default.env[10-12]
- docs/rhdh-local-guide/container-image-guide.md[11-19]
## Recommended Fix
Update the commented `RHDH_IMAGE` example, guide text, and guide link to use `quay.io/rhdh-community/rhdh:1.9.8`, while preserving instructions for intentionally selecting other image tags where appropriate.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Review mode: 🚀 Fast: This is a small, localized configuration pin updating two related container image tags, with no security-sensitive or broad behavioral logic changes.
Tip of the day
💡 Did you know, you can switch off images and animations for a plain-text comment
The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #317 and #318
Target branch
Description
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer