Skip to content

[release-1.9] chore: pin RHDH image version to 1.9.8 - #319

Merged
rm3l merged 2 commits into
release-1.9from
fix/release-1.9/pin_rhdh_to_z
Sep 11, 2026
Merged

rm3l merged 2 commits into
release-1.9from
fix/release-1.9/pin_rhdh_to_z

Conversation

@rm3l

@rm3l rm3l commented Sep 11, 2026

Copy link
Copy Markdown
Member

Followup to #317 and #318

Target branch

Description

Which issue(s) does this PR fix or relate to

  • Fixes #issue_number

PR acceptance criteria

  • Tests updated and passing
  • Documentation updated
  • Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Pin RHDH and plugin catalog images to 1.9.8

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Pins RHDH runtime and plugin installer defaults to patch release 1.9.8.
• Aligns the plugin catalog index with RHDH 1.9.8 for reproducible environments.
Diagram

graph TD
  C["Compose Config"] -->|"RHDH 1.9.8"| I["Plugin Installer"] -->|"prepared plugins"| R["RHDH Runtime"]
  E["Environment Defaults"] -->|"selects 1.9.8"| P["Catalog Index"] -->|"plugin metadata"| I
  C -->|"RHDH 1.9.8"| R
Loading
High-Level Assessment

Explicit patch-level pins are appropriate for a supported release branch because they keep the runtime, installer, and catalog deterministic and compatible. Floating 1.9 tags were considered but would allow unreviewed patch changes to alter local environments.

Files changed (2) +3 / -3

Other (2) +3 / -3
compose.yamlPin both RHDH services to image 1.9.8 +2/-2

Pin both RHDH services to image 1.9.8

• Changes the default image for the RHDH runtime and dynamic plugin installer from the floating 1.9 tag to 1.9.8. Existing RHDH_IMAGE overrides remain supported.

compose.yaml

default.envAlign the plugin catalog index with RHDH 1.9.8 +1/-1

Align the plugin catalog index with RHDH 1.9.8

• Updates the default Red Hat plugin catalog index image from 1.9.4 to 1.9.8, matching the pinned RHDH patch release.

default.env

@rhdh-qodo-merge

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Users can still select the old floating image 🐞 Bug ⚙ Maintainability
Description
The Compose default now uses quay.io/rhdh-community/rhdh:1.9.8, but the documented override and
container-image guide still tell users to use quay.io/rhdh-community/rhdh:1.9. Following those
instructions explicitly selects the unpinned image and undermines the release branch's version pin.
Code

compose.yaml[26]

+    image: ${RHDH_IMAGE:-quay.io/rhdh-community/rhdh:1.9.8}
Relevance

●●● Strong

Accepted history supports updating user-facing configuration documentation when defaults or image
configuration change.

PR-#149
PR-#127

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed Compose default is quay.io/rhdh-community/rhdh:1.9.8, while the repository's
user-facing override example and image guide still reference the old floating :1.9 tag. This makes
the documented explicit configuration inconsistent with the pinned release configuration.

compose.yaml[26-26]
default.env[10-12]
docs/rhdh-local-guide/container-image-guide.md[11-19]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The Compose default was pinned to RHDH 1.9.8, but the commented environment override and container-image guide still reference the floating `:1.9` tag. Users following those instructions can explicitly run a different, unpinned image than the release default.

## Fix Focus Areas
- default.env[10-12]
- docs/rhdh-local-guide/container-image-guide.md[11-19]

## Recommended Fix
Update the commented `RHDH_IMAGE` example, guide text, and guide link to use `quay.io/rhdh-community/rhdh:1.9.8`, while preserving instructions for intentionally selecting other image tags where appropriate.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Cross-repo context — repo relationships
  Explored: repo: redhat-developer/rhdh (branch: release-1.9, sha: 5666ee13)
Review mode: 🚀 Fast: This is a small, localized configuration pin updating two related container image tags, with no security-sensitive or broad behavioral logic changes.

Grey Divider

Tip of the day
💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge

Copy link
Copy Markdown
Contributor

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@rm3l

rm3l commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Merging as this is similar to #317, which was approved.

@rm3l
rm3l merged commit 60dfdd9 into release-1.9 Sep 11, 2026
27 checks passed
@rm3l
rm3l deleted the fix/release-1.9/pin_rhdh_to_z branch September 11, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant