Skip to content

feat(rhdh): upgrade default PostgreSQL to 18 - #546

Merged
zdrapela merged 1 commit into
redhat-developer:mainfrom
zdrapela:rhidp-13960-postgresql-18
Sep 21, 2026
Merged

zdrapela merged 1 commit into
redhat-developer:mainfrom
zdrapela:rhidp-13960-postgresql-18

Conversation

@zdrapela

@zdrapela zdrapela commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Description of the change

Updates the active RHDH chart to deploy Fedora PostgreSQL 18 by default and bumps the chart version to 2.6.0.

Warning

Existing embedded PostgreSQL databases require a dump-and-restore migration.

Related work:

Which issue(s) does this PR fix or relate to

Jira: https://redhat.atlassian.net/browse/RHIDP-13960

How to test changes / Special notes to the reviewer

This PR relies on the repository chart-testing CI. The upgrade path is covered by the existing Helm upgrade nightly job:

https://prow.ci.openshift.org/job-history/gs/test-platform-results-public/logs/periodic-ci-redhat-developer-rhdh-main-e2e-ocp-helm-upgrade-nightly

Local generation check:

pre-commit run --all-files

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in values.yaml and the generated README.
  • JSON Schema generation was run through pre-commit; no schema change was required.
  • Chart tests pass in CI.
  • The orchestrator-infra chart was not changed.

BREAKING CHANGE: Existing embedded PostgreSQL databases require dump-and-restore migration.

Assisted-by: OpenCode
@sonarqubecloud

Copy link
Copy Markdown

@zdrapela
zdrapela marked this pull request as ready for review September 21, 2026 13:18
@zdrapela
zdrapela requested a review from a team as a code owner September 21, 2026 13:18
@zdrapela zdrapela changed the title feat(rhdh)!: upgrade default PostgreSQL to 18 feat(rhdh): upgrade default PostgreSQL to 18 Sep 21, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Upgrade default embedded PostgreSQL to 18

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Deploys Fedora PostgreSQL 18 by default for the embedded RHDH database.
• Bumps the Helm chart to 2.6.0 and refreshes generated installation documentation.
• Requires dump-and-restore migration for existing embedded PostgreSQL data.
Diagram

graph TD
  C["Chart.yaml"] -->|"defines release"| H["RHDH Chart"] -->|"loads defaults"| V["values.yaml"] -->|"deploys"| P["PostgreSQL 18"]
  C -->|"documents version"| R["Generated README"]
  V -->|"documents defaults"| R
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Stage PostgreSQL 18 as opt-in
  • ➕ Provides existing installations a migration window
  • ➕ Avoids changing the embedded database during a minor chart upgrade
  • ➕ Allows broader upgrade validation before making version 18 the default
  • ➖ Delays PostgreSQL 18 adoption
  • ➖ Requires supporting and documenting two defaults across releases
  • ➖ Adds another coordinated release step

Recommendation: A staged opt-in followed by a major-version default switch would be safest for existing installations. If the coordinated RHDH release explicitly permits this breaking 2.6.0 change, the current centralized image update is straightforward, but migration requirements should remain prominent in release documentation and upgrade validation.

Files changed (3) +5 / -5

Enhancement (1) +1 / -1
values.yamlMake Fedora PostgreSQL 18 the default database image +1/-1

Make Fedora PostgreSQL 18 the default database image

• Changes the embedded PostgreSQL image repository from 'fedora/postgresql-15' to 'fedora/postgresql-18' while retaining the existing registry and tag settings.

charts/rhdh/values.yaml

Documentation (1) +3 / -3
README.mdRegenerate chart version and PostgreSQL defaults +3/-3

Regenerate chart version and PostgreSQL defaults

• Updates the version badge and installation example to 2.6.0. Refreshes the generated values table to document the Fedora PostgreSQL 18 image repository.

charts/rhdh/README.md

Other (1) +1 / -1
Chart.yamlBump the RHDH Helm chart to 2.6.0 +1/-1

Bump the RHDH Helm chart to 2.6.0

• Advances the chart package version from 2.5.0 to 2.6.0 for the PostgreSQL 18 default.

charts/rhdh/Chart.yaml

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Upgrades strand embedded databases 🐞 Bug ☼ Reliability
Description
values.yaml replaces PostgreSQL 15 with 18 while retaining the same enabled persistent volume, but
the shipped README template and installation notes contain no dump-and-restore warning or procedure.
An existing 2.5 installation following the documented helm upgrade command therefore starts the
new server against the old data directory without completing the required major-version migration.
Code

charts/rhdh/values.yaml[416]

+    repository: "fedora/postgresql-18"
Relevance

●●● Strong

Accepted precedents support documenting operational upgrade hazards and keeping generated chart
guidance synchronized.

PR-#407
PR-#542

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The default database remains enabled and persistent at the same mount and data paths after its
major-version replacement, while both documented installation forms use helm upgrade without a
database migration caveat and NOTES only reports access information.

charts/rhdh/values.yaml[409-418]
charts/rhdh/values.yaml[442-450]
charts/rhdh/README.md.gotmpl[80-99]
charts/rhdh/templates/NOTES.txt[1-12]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Existing embedded PostgreSQL volumes require dump-and-restore before PostgreSQL 18 can replace PostgreSQL 15, but the chart artifact still presents an unqualified Helm upgrade command and emits no upgrade warning. Users upgrading from 2.5 can consequently reuse the old persistent data directory with the new database image.

## Fix Focus Areas
- charts/rhdh/README.md.gotmpl[80-99]
- charts/rhdh/templates/NOTES.txt[1-12]
- charts/rhdh/values.yaml[409-450]

## Recommended Fix
Add a prominent 2.5-to-new-version migration section to the README template with the supported dump, fresh PostgreSQL 18 initialization, and restore sequence; regenerate README.md and emit an upgrade-specific NOTES warning when embedded PostgreSQL is enabled. Add upgrade coverage that begins with a populated PostgreSQL 15 persistent volume and verifies the documented migration path.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Breaking upgrades look backward-compatible 🐞 Bug ≡ Correctness
Description
Chart.yaml labels the explicitly breaking PostgreSQL replacement as 2.6.0, a minor release under
the repository-required Semantic Versioning policy. Consumers accepting compatible 2.x updates can
therefore select it without a major-version opt-in even though the persistent embedded database
requires dump-and-restore.
Code

charts/rhdh/Chart.yaml[4]

+version: 2.6.0
Relevance

●● Moderate

Breaking-change SemVer precedent is mixed; prior minor-bump feedback was rejected, but this
explicitly documents a breaking migration.

PR-#523

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The contribution policy requires Semantic Versioning, while the chart changes its enabled persistent
database from PostgreSQL 15 to PostgreSQL 18 but advances only from 2.5.0 to 2.6.0.

CONTRIBUTING.md[5-11]
charts/rhdh/Chart.yaml[1-5]
charts/rhdh/values.yaml[409-418]
charts/rhdh/values.yaml[442-450]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PostgreSQL replacement is a breaking change, but the chart version is only incremented from 2.5.0 to 2.6.0. This violates the repository's Semantic Versioning policy and allows consumers using compatible 2.x ranges to receive a breaking database upgrade.

## Fix Focus Areas
- charts/rhdh/Chart.yaml[1-5]
- charts/rhdh/README.md[1-39]

## Recommended Fix
Increment the chart to the next major version, update every generated version reference accordingly, and regenerate the README through the repository's documented pre-commit workflow.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials
✅ Cross-repo context — repo relationships
  ⚠️ Failed to retrieve: redhat-developer/rhdh
  ⚠️ Failed to retrieve: redhat-developer/rhdh-operator
Review mode: ⚖️ Balanced: This changes the default embedded PostgreSQL runtime and requires a potentially breaking dump-and-restore migration, so it warrants a complete review despite the small diff.

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 21, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@zdrapela
zdrapela merged commit 22040cd into redhat-developer:main Sep 21, 2026
7 of 8 checks passed
Comment thread charts/rhdh/Chart.yaml
name: redhat-developer-hub
type: application
version: 2.5.0
version: 2.6.0

@rm3l rm3l Sep 21, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 2.6.0
version: 3.0.0

I'd bump this to 3.0.0 => #547

rm3l added a commit that referenced this pull request Sep 21, 2026
rm3l added a commit that referenced this pull request Sep 21, 2026
…eSQL major bump (#547)

* chore(rhdh): bump chart version to 3.0.0

Followup to #546

* Update version in README for RHDH Helm Chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants