Change TLS termination to Reencrypt and Redirect on Insecure

[supernovae]

What type of PR is this?

/kind bug

What does this PR do / why we need it:

When this operator is installed, the default route created is pass through so users get an invalid certificate warning since the gitops secret for tls is a generic.

Lots of corporate managed browsers do NOT let users bypass invalid certificates through accepting cert or typing "thisisunsafe"

Default behavior for fresh install should be a working route using the apps* route.

Have you updated the necessary documentation?

No documentation necessary, without this PR, we should have a documentation bug. So if this isn't approved, we should update our docs on how to either update the certificate or update the CRD to use reencrypt.

Which issue(s) this PR fixes:

Fixes # GITOPS-3839

Test acceptance criteria:

• E2E Test

How to test changes / Special notes to the reviewer:

Install operator, configure gitops CRD and open default link to ArgoCD - should no longer get SSL warning or blocked browser warning.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iam-veeramalla for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @supernovae. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[svghadi]

/ok-to-test

[openshift-ci]

@supernovae: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.17-ci-index-gitops-operator-bundle	e8dd445	link	true	/test v4.17-ci-index-gitops-operator-bundle
ci/prow/v4.17-e2e	e8dd445	link	true	/test v4.17-e2e
ci/prow/v4.17-images	e8dd445	link	true	/test v4.17-images
ci/prow/v4.17-kuttl-parallel	e8dd445	link	true	/test v4.17-kuttl-parallel
ci/prow/v4.17-kuttl-sequential	e8dd445	link	true	/test v4.17-kuttl-sequential
ci/prow/v4.14-kuttl-sequential	e8dd445	link	true	/test v4.14-kuttl-sequential
ci/prow/v4.14-e2e	e8dd445	link	true	/test v4.14-e2e
ci/prow/v4.14-kuttl-parallel	e8dd445	link	true	/test v4.14-kuttl-parallel
ci/prow/v4.14-ci-index-gitops-operator-bundle	e8dd445	link	true	/test v4.14-ci-index-gitops-operator-bundle
ci/prow/v4.14-images	e8dd445	link	true	/test v4.14-images
ci/prow/v4.19-e2e	e8dd445	link	true	/test v4.19-e2e
ci/prow/v4.19-kuttl-sequential	e8dd445	link	true	/test v4.19-kuttl-sequential
ci/prow/v4.19-ci-index-gitops-operator-bundle	e8dd445	link	true	/test v4.19-ci-index-gitops-operator-bundle
ci/prow/v4.19-images	e8dd445	link	true	/test v4.19-images
ci/prow/v4.19-kuttl-parallel	e8dd445	link	true	/test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.