[DeadCode] Skip with assign to call with target has #[NoDiscard] attribute on RemoveUnusedVariableAssignRector#7950
Merged
TomasVotruba merged 6 commits intomainfrom Apr 2, 2026
Merged
Conversation
samsonasik
changed the title
Member
Author
|
@TomasVotruba ready 👍 |
TomasVotruba
reviewed
Apr 2, 2026
Comment on lines
+276
to
+280
| if ($assign->expr instanceof FuncCall | ||
| || $assign->expr instanceof StaticCall | ||
| || $assign->expr instanceof MethodCall | ||
| || $assign->expr instanceof New_ | ||
| || $assign->expr instanceof NullsafeMethodCall) { |
Member
There was a problem hiding this comment.
How about instanceof CallLike?
Member
Author
There was a problem hiding this comment.
That cause phpstan notice, see
https://github.com/rectorphp/rector-src/actions/runs/23905789349/job/69714124150#step:5:19
use the required instance fix it.
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://3v4l.org/YXB9c#v8.5.3 vs https://3v4l.org/RudO3#v8.5.3