Skip to content

feat: claim_songstats_backfill_rows RPC for the backfill worker #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweetmantech merged 1 commit into from
Jun 11, 2026
Merged

feat: claim_songstats_backfill_rows RPC for the backfill worker #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions supabase/migrations/20260611000000_claim_songstats_backfill_rows.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
-- Atomic claim function for the Songstats backfill worker (recoupable/chat#1791).
-- FOR UPDATE SKIP LOCKED can't be expressed through supabase-js, so the worker
-- claims its batch via this RPC: pending rows in value order (rank_score DESC),
-- marked in_progress and returned in one statement. Concurrent workers skip
-- each other's locked rows instead of blocking.
--
-- SECURITY INVOKER (default): RLS on songstats_backfill_queue has no policies,
-- so only the service-role worker (which bypasses RLS) can claim rows; anon /
-- authenticated callers get zero rows even if they can execute the function.

CREATE OR REPLACE FUNCTION claim_songstats_backfill_rows(batch_size integer)
RETURNS SETOF songstats_backfill_queue
LANGUAGE sql
AS $$
UPDATE songstats_backfill_queue q
SET status = 'in_progress', updated_at = now()
WHERE q.id IN (
SELECT id FROM songstats_backfill_queue
WHERE status = 'pending'
ORDER BY rank_score DESC
FOR UPDATE SKIP LOCKED
LIMIT batch_size

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: batch_size is not validated before use in LIMIT, so NULL claims the entire queue and negative values raise a SQL error.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At supabase/migrations/20260611000000_claim_songstats_backfill_rows.sql, line 22:

<comment>`batch_size` is not validated before use in `LIMIT`, so `NULL` claims the entire queue and negative values raise a SQL error.</comment>

<file context>
@@ -0,0 +1,25 @@
+    WHERE status = 'pending'
+    ORDER BY rank_score DESC
+    FOR UPDATE SKIP LOCKED
+    LIMIT batch_size
+  )
+  RETURNING q.*;
</file context>
Suggested change
LIMIT batch_size
LIMIT GREATEST(COALESCE(batch_size, 0), 0)

)
RETURNING q.*;
$$;