MYC-1328: Stop automatic artist switching during chat creation#469
Merged
sidneyswift merged 1 commit intoMar 19, 2025
Conversation
- Remove auto-selection of first artist in usePrompts.tsx - Remove artists and setSelectedArtist from hook dependencies - Keep user's explicitly selected artist instead of auto-switching This fixes the bug where creating a new chat would automatically switch back to the first artist in the list instead of keeping the user's selected artist.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
sweetmantech
approved these changes
Mar 19, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When creating a new chat with a non-default artist selected (e.g., Chillpill), the app would automatically switch back to the first artist in the list. This happened because
usePrompts.tsxhad logic that would automatically select the first artist when no artist was selected, but this logic was triggering incorrectly during chat creation.Solution
Modified
usePrompts.tsxto:artistsandsetSelectedArtistfrom the hookChanges
hooks/usePrompts.tsxTesting
To verify this fix:
Other Bugs (Open Tickets)