fix(socials): key artist-social lists on social_id (not the dropped id)

[sweetmantech]

Part of #1833 — companion to recoupable/api#735 (which drops the dead account_socials.id from /api/artists/{id}/socials, keeping social_id). Base: main.

Change

• types/Social.ts: add social_id (shared type — id kept for other consumers).
• GetArtistSocialsResult.tsx + ArtistSocial.tsx: React key={social.id} → key={social.social_id}.
• docs field name socials[].id → socials[].social_id.

Merge alongside/after api#735 (the api response then carries social_id, not id). tsc clean — no Social type errors.

🤖 Generated with Claude Code

---

Summary by cubic

Use social_id for React keys in artist social lists and add social_id to the Social type to match the API. Prevents key warnings/mismatches when account_socials.id is removed; pairs with recoupable/api#735.

• Bug Fixes
  • Use key={social.social_id} in GetArtistSocialsResult and ArtistSocial.
  • Add social_id to Social type (keep id for other consumers).
  • Update docs field name to socials[].social_id.

^{Written for commit a28647f. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
chat	Ready	Preview	Jul 1, 2026 4:12pm

[coderabbitai]

Warning

Review limit reached

@sweetmantech, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f83b1c4-90a2-4438-b6df-b78e0c539123

📥 Commits

Reviewing files that changed from the base of the PR and between 0df5044 and a28647f.

⛔ Files ignored due to path filters (1)

• types/Social.ts is excluded by none and included by none

📒 Files selected for processing (3)

• app/docs/account/constants.ts
• components/VercelChat/tools/ArtistSocial.tsx
• components/VercelChat/tools/GetArtistSocialsResult.tsx

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/socials-react-keys

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

1 issue found across 4 files

Confidence score: 4/5

• In app/docs/account/constants.ts, the docs rename the field to socials[].social_id but exampleResponse and the TypeScript interface example still show id, which can mislead integrators into implementing the wrong contract; align both examples to social_id before merging to avoid downstream API confusion.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/docs/account/constants.ts">

<violation number="1" location="app/docs/account/constants.ts:94">
P2: Doc field renamed to `socials[].social_id` but `exampleResponse` and TypeScript interface example still use `id` — mismatch will confuse developers.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Doc field renamed to socials[].social_id but exampleResponse and TypeScript interface example still use id — mismatch will confuse developers.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/docs/account/constants.ts, line 94:

<comment>Doc field renamed to `socials[].social_id` but `exampleResponse` and TypeScript interface example still use `id` — mismatch will confuse developers.</comment>

<file context>
@@ -91,7 +91,7 @@ export const responseProperties = [
   },
   {
-    name: "socials[].id",
+    name: "socials[].social_id",
     type: "string",
     description: "Unique identifier for the social account",
</file context>

[sweetmantech]

Add a note to the issue noting to delete the /docs directory. We use the official docs codebase, not this subroute, for documentation.