feat(chat): session-scoped sidebar rename + archive-on-delete by arpitgupta1214 · Pull Request #1758 · recoupable/chat

arpitgupta1214 · 2026-05-29T18:50:24Z

Stacked on chat#1756. Two related changes to the sidebar's chat actions:

Rename — session-scoped PATCH

The rename flow was still hitting the legacy PATCH /api/chats shape ({ chatId, topic }), which only touched the rooms table. Repoint at PATCH /api/sessions/{sid}/chats/{cid} with { title } so the canonical chat row is updated.

updateChat({ sessionId, chatId, title }) → PATCH /api/sessions/{sid}/chats/{cid}.
useRenameModal sends title (was topic).

Delete — archive the owning session

Instead of removing the chat row, the "Delete chat" action now archives the owning session via PATCH /api/sessions/{sid} { status: "archived" }. The api filters chats from archived sessions out of GET /api/chats (api#630), so the row disappears from the sidebar; archive also triggers stopSandboxOnArchive so we tear down running sandboxes for chats the user said they're done with. The whole thing is reversible from the admin side.

This also sidesteps the 400 Cannot delete the only chat in a session guard that blocks chat-row deletes when a session has a single chat — archive has no such constraint.

New lib/sessions/archiveSession.ts → PATCH /api/sessions/{sid} { status: "archived" }.
useDeleteChat calls it (drops the chatId arg).
DeleteConfirmationModal no longer passes chatId.

Caveat

If a session ever has >1 chat, archiving from one row hides the others too. Today every sidebar row maps 1:1 to its own session (POST /api/sessions mints a session + single chat), so this is a no-op in practice — but worth knowing before we add a UI that creates additional chats inside an existing session.

Dependencies

Requires api#630 (filter archived sessions from GET /api/chats) live; until that lands, archived sessions still appear in the list.
Base auto-rebases to test once chat#1756 merges.

Test plan

Rename a chat → sidebar shows new title after refetch. Verify via GET /api/chats that title updated server-side.
Delete a single chat → row disappears after refetch. Verify the owning session is status: "archived" via GET /api/sessions/{sid}.
Bulk delete multiple rows. All disappear.
Delete a chat that's the only chat in its session (previously 400'd). Now succeeds.

Both mutations were still hitting the legacy rooms-shaped endpoints (DELETE /api/chats with body { id }, PATCH /api/chats with { chatId, topic }), which only touch the rooms table — workflow chats stayed intact in chats / chat_messages / sessions. Repoint both at the session-scoped routes so deletes cascade through chat_messages / chat_reads, and renames update the canonical title field. - deleteChat takes (sessionId, chatId, accessToken) and calls DELETE /api/sessions/{sid}/chats/{cid}. - updateChat takes (sessionId, chatId, title) and calls PATCH /api/sessions/{sid}/chats/{cid} with { title }. - useDeleteChat and DeleteConfirmationModal pass through sessionId from the Conversation row. - useRenameModal passes sessionId + title (was topic) through to updateChat. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

vercel · 2026-05-29T18:50:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
chat	Ready	Preview	May 31, 2026 10:08pm

coderabbitai · 2026-05-29T18:50:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

main
test

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 985ddaab-c888-4a82-98ba-fa617181d7d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/sidebar-delete-rename-session-scoped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Requires human review: This PR modifies API endpoints and payloads for chat deletion and renaming, moving from legacy rooms-shaped routes to session-scoped routes; such changes carry moderate risk of breakage if the new endpoints are not yet available or behave differently, and they depend on the sessionId field from...

Re-trigger cubic}

…o feat/sidebar-delete-rename-session-scoped

Switch the sidebar's delete action to soft-delete via session archive instead of removing the chat row. The api side filters chats whose session is `archived` out of `GET /api/chats` (api#630), so the row disappears from the sidebar; archive also triggers the existing `stopSandboxOnArchive` lifecycle path on the api so we stop running sandboxes for chats the user told us they're done with. This also unblocks deleting the last chat in a session, which the api previously refused with `400 Cannot delete the only chat in a session` — archive has no such constraint. - New `lib/sessions/archiveSession.ts` → `PATCH /api/sessions/{sid} { status: "archived" }`. - `useDeleteChat` calls it (drops the `chatId` arg). - `DeleteConfirmationModal` no longer passes `chatId`. - Remove the now-unused `lib/chats/deleteChat.ts`. Caveat for reviewers: if a session ever has >1 chat, archiving from one row will hide the others too. Today every sidebar row corresponds 1:1 with its own session (each `POST /api/sessions` mints a session + single chat), so this is a no-op in practice — but worth knowing before we add a UI that creates additional chats inside an existing session. Depends on api#630 for the filter; until that lands, archived sessions will still show up in the chat list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

cubic-dev-ai

2 issues found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="hooks/useDeleteChat.ts">

<violation number="1" location="hooks/useDeleteChat.ts:29">
P1: Delete action now archives whole session, not target chat. Wrong endpoint and payload for chat delete. Restore chat-scoped delete call with `chatId`.</violation>
</file>

<file name="components/Sidebar/Modals/DeleteConfirmationModal.tsx">

<violation number="1" location="components/Sidebar/Modals/DeleteConfirmationModal.tsx:68">
P1: Missing chatId in delete call. Session-only delete cannot target one chat. Pass chatId through this flow.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-05-31T22:09:42Z

+        );
      }
-      return deleteChat(roomId, accessToken);
+      return archiveSession(sessionId, accessToken);


P1: Delete action now archives whole session, not target chat. Wrong endpoint and payload for chat delete. Restore chat-scoped delete call with chatId.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At hooks/useDeleteChat.ts, line 29: <comment>Delete action now archives whole session, not target chat. Wrong endpoint and payload for chat delete. Restore chat-scoped delete call with `chatId`.</comment> <file context> @@ -1,27 +1,32 @@ ); } - return deleteChat(sessionId, chatId, accessToken); + return archiveSession(sessionId, accessToken); }, }); </file context>

cubic-dev-ai · 2026-05-31T22:09:42Z


        try {
-          await deleteChat(chat.id);
+          await deleteChat({ sessionId: chat.sessionId });


P1: Missing chatId in delete call. Session-only delete cannot target one chat. Pass chatId through this flow.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At components/Sidebar/Modals/DeleteConfirmationModal.tsx, line 68: <comment>Missing chatId in delete call. Session-only delete cannot target one chat. Pass chatId through this flow.</comment> <file context> @@ -52,15 +65,18 @@ const DeleteConfirmationModal = ({ isOpen, onClose, chatRoom, chatRooms, onDelet try { - await deleteChat({ sessionId: chat.sessionId, chatId: chat.id }); + await deleteChat({ sessionId: chat.sessionId }); } catch (chatError) { - console.error(`Error deleting chat ${chat.topic || "Chat"}:`, chatError); </file context>

arpitgupta1214 · 2026-05-31T22:11:04Z

E2E re-test after consolidating archive change

Tested the chat preview pointed at the api#630 preview so the full archive → list-filter path is exercised end-to-end. The pointing is done client-side via sessionStorage:

sessionStorage.setItem(
  'recoup_api_override',
  'https://api-git-feat-exclude-archived-from-chats-list-recoup.vercel.app'
);

Setup: Taylor Swift with 3 chats, all in single-chat sessions (worst-case for the old delete guard).

Action	UI	Network call	Backend state	Sidebar
Rename → "rename-take-2"	"New chat" row updates, jumps to top	`PATCH /api/sessions/ed432b84-…/chats/da78eec1-…` → 200	`chats.title = "rename-take-2"`	3 chats, renamed at top
Delete (single-chat session — previously 400'd)	Row disappears	`PATCH /api/sessions/ed432b84-…` → 200	`sessions.status = "archived"`	3 → 2 chats
Verify via api	—	`GET /api/sessions/ed432b84-…` returns `status: "archived"`; `GET /api/chats?artist_account_id=…` returns 2 chats, archived row absent	—	—

All four PR test-plan bullets pass.

Not exercised separately

Bulk delete via selection mode — runs the same useDeleteChat hook in a loop, so per-row behavior is identical to the single-delete path above. Skipped to keep the run short.

arpitgupta1214 requested a review from sweetmantech as a code owner May 29, 2026 18:50

cubic-dev-ai Bot reviewed May 29, 2026

View reviewed changes

vercel Bot deployed to Preview – chat May 29, 2026 18:53 View deployment

sweetmantech mentioned this pull request May 30, 2026

Post-cutover plan: chat.recoupable.com → /api/chat/workflow #1747

Closed

26 tasks

Merge remote-tracking branch 'origin/feat/sidebar-canonical-urls' int…

e4b8c30

…o feat/sidebar-delete-rename-session-scoped

vercel Bot deployed to Preview – chat May 31, 2026 21:21 View deployment

arpitgupta1214 changed the title ~~feat(chat): point sidebar delete + rename at session-scoped api~~ feat(chat): session-scoped sidebar rename + archive-on-delete May 31, 2026

arpitgupta1214 mentioned this pull request May 31, 2026

feat(chat): archive the session for sidebar "Delete chat" #1762

Closed

3 tasks

vercel Bot deployed to Preview – chat May 31, 2026 22:08 View deployment

cubic-dev-ai Bot reviewed May 31, 2026

View reviewed changes

sweetmantech deleted the branch feat/sidebar-canonical-urls June 1, 2026 16:14

sweetmantech closed this Jun 1, 2026

sweetmantech mentioned this pull request Jun 1, 2026

feat(chat): session-scoped sidebar rename + archive-on-delete #1763

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(chat): session-scoped sidebar rename + archive-on-delete#1758

feat(chat): session-scoped sidebar rename + archive-on-delete#1758
arpitgupta1214 wants to merge 3 commits into
feat/sidebar-canonical-urlsfrom
feat/sidebar-delete-rename-session-scoped

arpitgupta1214 commented May 29, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 29, 2026 •

edited

Loading

Review skipped

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot May 31, 2026

Uh oh!

cubic-dev-ai Bot May 31, 2026

Uh oh!

arpitgupta1214 commented May 31, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

arpitgupta1214 commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rename — session-scoped PATCH

Delete — archive the owning session

Caveat

Dependencies

Test plan

Uh oh!

vercel Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

arpitgupta1214 commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E re-test after consolidating archive change

Not exercised separately

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arpitgupta1214 commented May 29, 2026 •

edited

Loading

vercel Bot commented May 29, 2026 •

edited

Loading

coderabbitai Bot commented May 29, 2026 •

edited

Loading

arpitgupta1214 commented May 31, 2026 •

edited

Loading