Repository navigation
ibd: drain-rank tip+1 race; later holes stay solo - #625
Merged
Merged
Conversation
At ~912k leftover densify FIFO plus short-queue ranking left four slow racers on tip+1 (64KiB ticks are not hole progress). Race four peers on tip+1 only, pick by expected drain wait, and drop an owner that still has other inflight so a peer that can start the hash can race. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mainnet ~912k sat
hole=1/conf blks=0while leftover densify FIFO kept four slow short-queue racers "live" on 64KiB ticks. Getdata cannot be cancelled; peer-level ticks are not progress on the hole hash.(queue+1)/EWMA, not inflight count, so a fast peer with leftover densify beats an idle slow peer.in_flight.len() > 1) even with recent rx, when another live peer exists, so a peer that can start the hole can race.Densify cap 0 while a tip hole is open is unchanged. Pre-hole (when
hole=is 0) is unchanged.Test plan
cargo test -p rbitcoin-net --lib assign::testscargo clippy --workspace --all-targets -- -D warningsMade with Cursor