Replies: 40 comments 153 replies
|
building for android fails for me with a fresh generated project |
|
@cortinico that issue was that I had multiple NDK installed, I removed all but one ( v21.4.7075529 ) then cleaned & rebuild the app. |
Yup we can look into it. I'm a bit afraid we might have some Gradle Plugin (not necessarily ours) that has JDK11 bytecode so every Gradle invocation on JDK8 would just fail with an invalid bytecode error. AGP is doing somethign similar though so we can take a look at how it's done there.
@a-eid Glad to hear New Architecture works \o/. As for the multiple NDKs: Ideally AGP should pick the correct one. I'm not entirely sure why you experienced this failure but is something we should keep an eye on. |
|
Detect JVM version and error if it is not in the expected range example groovy, in production use 1+years, maybe useful? jvmVersion = Jvm.current().javaVersion.majorVersion
if (jvmVersion != "11" && jvmVersion != "14" && jvmVersion != "16") {
println "\n\n\n"
println "**************************************************************************************************************"
println "\n\n\n"
println "ERROR: AnkiDroid builds with JVM version 11, 14, or 16."
println " Incompatible major version detected: '" + jvmVersion + "'"
println "\n\n\n"
println "**************************************************************************************************************"
println "\n\n\n"
System.exit(1)
} |
|
(in the meantime, I've added to the release notes a warning about JDK11 being required: https://github.com/facebook/react-native/releases/tag/v0.68.0-rc.0) |
|
@mikehardy by your solution, i have made this PR react/react-native#33048 |
|
When i enable proguard on the release build of Android it crashes. It works fine without it though. |
|
It's crashing with the new architecture enabled. I'm working on getting a logcat as we speak |
|
Hm, I think we discussed this issue with @cortinico before. It probably doesn't respect |
|
|
I've opened an issue for the problem mentioned by @ShikaSD here react/react-native#33008 It's up for grab if someone wants to help us 🙏 As for your problem @TheRogue76, could you provide the full logcat. I see you've provided 4 chunks of it. Some of those are not actually crashes. For instance the |
|
Should be fixed in v0.68.0-rc.1 :) |
|
Is there a reason why the release page advises to install adoptopenjdk11 for mac user which has been discontinued? |
|
Yes ideally we should suggest to install Temurin: react/react-native-website#2817 The fact is that we haven't really tested locally if everything works with that specific JDK distribution. @danilobuerger if you, or someone else, are able to do a run of the app from a new template on both 0.67 and 0.68RC with Temurin, I'm totally fine merging #2817 |
|
FWIW, we've been using Temurin since September of last year and have had no issues: microsoft/react-native-test-app#524 |
|
FYi I've just been using |
|
@Titozzz It's not good advice for M1 users though. It will install x86 JDK that will perform significantly slower than arm64. |
|
The formulae is avaible for arm64 tho, so it should be fine no ? Or you need to run it with |
|
I am getting this error. please suggest solution if you have i just want to try 68 on android. |
|
do you have JDK11 installed? Does a 0.67 project run fine on your machine? |
yes @kelset |
I'm not entirely sure what happened to your Gradle Cache. I would give it a try with |
Hi @cortinico , thanks, it is working now. that was JDK version issue. |
|
Android doesn't build at all for me: StacktraceAnd when Flipper is enabled: StacktraceI am using JDK 11, and I have cleaned out |
|
I need to look further into this, but it seems like that for some reason Essentially there are two |
|
We can probably cut it out the AAR, for consistency :) |
|
Yup that's the PR for it: react/react-native#33038 I think we should pick this for the next RC as it's affecting users on both old and new arch 👍 |
|
Should be fixed in v0.68.0-rc.1 :) |
|
Thanks! Can confirm 0.68.0-rc.1 works without having to add the |
|
I suggest to cherrypick react/react-native@eb08af5, this fixes store as global object for flipper debugging. this will help developers to copy JSON responses from the debugger |
|
let's cherry pick this react/react-native@848ba6f since it was the last piece of tooling bump missing |
|
Will also cherry pick react/react-native@09e418e and react/react-native@48318b1 to fix problems with new architecture builds and react/react-native@6239e2f, to be consistent with commits in 0.67.2 |
|
Any chance we can get this fix in Folly included? That should remove the need for the postinstall phase in cocoapods that was added in RN 0.66. |
|
My understanding is that would mean waiting for Folly's next release next Monday (https://github.com/facebook/folly/releases seems it's automatically releasing every Monday), then bumping Folly in RN OSS AND also bump Flipper version to pick a newer version of Flipper that also uses this version of Folly. So it's not likely that it will happen for 0.68-rc1 but we should keep an eye on this as it would allow to remove some of the workarounds scripts that were added, right @mikehardy ? |
|
Such change could be a bit too big to pick in 0.68, so we might want to postpone it until 0.69 :) |
|
I think it might be a bit much for 0.68, touching this stuff has a history of failed builds in corner cases afterwards. I guess stated differently: I don't have the time personally to be responsive and do the 1-2 follow-up PRs that always seem necessary. More concretely I think that PR (1688 in folly repo) will fix half of the remaining bits in the post install workaround cocoapods hook, I don't believe it will fix this one yet, but I have no current testing to base this on, just I'm not aware it's been specifically addressed: |
|
Android NDK currently does not support Apple Silicon. So it requires to do some workarounds(such as android/ndk#1299 (comment)) to enable new architecture. It's not a blocker I guess, but I think it's worth mentioning. |
|
I was able to get it to run on an M1 by:
|
|
Hey @nextriot - fantastic report w/details - I don't want to discount your experience but I do want to confirm - was it 100% necessary to add ndk.dir to local.properties? I was under the impression that was deprecated. I actually have scripting infrastructure in my environment convergence scripts for colleagues that removes ndk.dir from local.properties if it sees it, and in my experience the build.gradle change was sufficient. But! Big but, I have not built new arch here for M1. Perhaps it's strictly required there, if so that's interesting https://developer.android.com/studio/projects/install-ndk#install_ndk_and_cmake_automatically
|
|
Hey @mikehardy, I tried by simply updating the |
|
Really unexpected result, thanks for reporting that you actually tried it. It appears either the google docs are wrong, or there is a google toolchain bug that could be lodged on their issuetracker (have you searched there? Just curious), or '???' (the possibility we're just misunderstanding something, always a possibility). But you've provided a recipe that does work, misunderstanding or not, and that's fantastic |
|
RN wiki guided to set NDK version with I can see the RN source overrides the NDK version using system env: https://github.com/facebook/react-native/blob/c418bf4c8fe8bf97273e3a64211eaa38d836e0a0/ReactAndroid/build.gradle#L264-L268 |
|
Just a heads up for everyone keeping an eye on this discussion (see https://github.com/facebook/react-native/pull/32993/files#r798720480): This commit react/react-native@0912ee1 is a breaking change on the iOS template. Essentially, creating an app from template on 0.67 and bumping RN to 0.68 results on a build failure on iOS. |
|
I don't know if it worth mentioning but after enabling new architecture i got bunch of this warnings for different .so files. It builds without issue although it takes around 10 minutes in a freshly created app (0.68.0-rc.1). |
For those files, such as
That's (sadly) expected. I added a note in the New Architecture Guide: react/react-native-website#2879 I'm going to publish a page on how to speed-up that build time in the near future. |
|
For i saw I am testing |
|
Is it happening with the default configuration or the new arch enabled? |
|
@ShikaSD it was happening with the default configuration. |
|
I'm upgrading an existing app, which depends on bunch of third-party libs, and it throws error while merging dex in release build. I'd tried deleting I'm not sure which one cause this error, trying to find out. Build Output |
|
Hm, it says that both ReactAndroid (RN artifact) and app module declare the same class. By any chance, do you have a copy of |
|
I can't tell from your scan what's going on. As @ShikaSD said:
Also I'll just |
|
Hmm, there is no |
|
This are your dependencies and here all the libraries that mention the class. I'll keep reading 🙏 |
|
I checked that react/react-native#33134 effectively resolves this issue too. |
|
It seems that creating archives on RN 0.68 RC1 is broken on M1 Macs. It fails during the linking stage due to Folly errors. I keep getting these errors even on a sample project created with
|
|
Does it compile if you disable the new architecture? |
|
It dose successfully compiled when disable the new architecture or when disable flipper, or in a debug build. It seems Xcode trying to link wrong library Flipper-Folly uses folly |
|
This demonstrates a compilation failure on iOS in static frameworks mode. The same thing works on 0.67.x and has worked for many releases (but did not work on previous 0.68.0-rcs either, I just had not published the result). Not sure what changed? https://github.com/mikehardy/rnfbdemo/blob/rn68/make-demo.sh (commit mikehardy/rnfbdemo@f624617 specifically is where it's set up to show the failure) The script builds the whole reproduction from scratch so it should reproduce on any macOS machine? (:crossed_fingers: ) |
|
i can also reproduce this error and here is the solution pr: react/react-native#33379 |
|
@Kudo really nice find! I'll collaborate with you on 33379 to confirm it in my test scenario |
|
@Kudo has fixed my problem with react/react-native#33379 🏆 - I commented there on the tests I ran and my results (all good) and hopefully it is merged shortly. If/when it is, a pick of whatever the commit for the merge is will resolve this. Until then it appears anyone using static frameworks for iOS builds with Fabric disabled will not work on rn68 |
|
Hey all, just a heads up that we're currently blocked here. Specifically react/react-native#33379 suggested by @Kudo can't be merged as it is as it's breaking the internal builds. If anyone is able to help us here, it would be more than appreciated 🙏 |
|
We are unblocked! Nothing's going to stand in the way of the combined effort here ;-) - 🏆 @Kudo and @cortinico I think this is the one to pick: react/react-native@a6c2846 |
|
Task :ReactAndroid:generateCodegenSchemaFromJavaScript FAILED Steps to reproduce: |
|
The build is failing as |
|
I have that directory. But I do not have yarn, I have npm. Does this version only work with yarn? npx react-native run-android throws the same error |
|
If you don't have yarn installed, the task will fail. If you install yarn, it should be green. This is an improvement we could look into doing, but the assumption is that you have Please install and verify that it works correctly for you 👍 |
|
@cortinico if that's correct then CLI doctor should get an enhancement issue for yarn installation detection shouldn't it? I wasn't under the impression yarn was a strict requirement for react-native to function up to now |
I think that's the case, but it's never mentioned on the website. We always say that you can use either I don't think we should work on the doctor, but ratehr update the task to call |
|
I've done some testing of RN Specifically, we need to update the template including those two lines: The issue went unnoticed as I believe me + other developers had |
|
Let's merge it into main template? :) |
|
Merged here: react/react-native@2fdbf6a |
|
Just saw this in react-native weekly digest - seemed like this affects back to the 0.66 tree and was finally merged, but recently enough it is not on the pick list here? react/react-native@8d50bf11335 - fixes a regression in Switch behavior. I'll post similar comments on 0.67 / 0.66 release planning threads but @d4vidi / @asafkorem / @jonathanmos might do well to keep eyes on it 👀 - my comments are intended to bridge people into this maybe-pick-it conversation but I am likely not most aware person for this change |
|
@mikehardy amazing, we were just discussing this! Indeed, we definitely want this in for both 0.68 and 0.67.4 - @jonathanmos will provide all the details ❤️ |
|
Thanks @mikehardy! Yes, it would be very good to have this included as we currently have to use an ugly workaround to deal with this regression |
|
if it's something to have in 0.67 can y'all put a comment in that discussion? so that we won't forget |
|
already done :-) |
|
It would be nice to pick react/react-native@56dda14 as it allows using fabric folly headers from other libs |
|
Can this land in 0.69? Or is there a specific reason why this needs to picked up in 0.68? |
|
As far as I understand, the 0.68 release is about getting more people to opt into fabric. So I think it makes sense to include this in 0.68 as turning it on and having a library that uses those folly headers will break otherwise. (Notably react-native-safe-area-context in v4 with new arch, which is pretty popular) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been hidden.
This comment has been hidden.
|
Hello, I'm facing a problem in version Step by reproduce
Expected behavior
|
|
This seems to be the issue: react/react-native#33383 |
|
So I found the offending commit: react/react-native@e494e4b . By reverting it, the text is selectable again. Maybe @mdvacca (author of the commit) has some insight? |
|
Yeah, I think feature flag is working incorrectly, it should delegate to |
|
This was reverted in react/react-native@bfd72ec which we should pick (wont automerge, because react/react-native@34d3373 is in between) to make text selectable again. |
|
adding both commits to top message for visibility |
|
Hello, I'm facing a problem in version 0.68.0-rc.2 when build ios
|
|
@lamlengend98 with apologies, I have no idea what to do with the information on that screenshot as it does not specify the steps you took to get to that error, or what you have tried already to work around it. https://stackoverflow.com/help/how-to-ask |
|
Damn, I am getting the same thing now in one of my test repos and I have no idea how I got to that point 😅 |
|
Ok figured this one out. Apparently these errors happen when enabling the new architecture but forgetting to include in the podfile (which is included in the template podfile). So there is nothing to fix here, but this can happen if devs are not careful when upgrading and forgetting this line. |
|
Please pick react/react-native@42b01a3 so we don't have any hard coded absolute paths in projects which could lead to hard to debug problems in the wild. |
|
I discovered some more path troubles with cocoapods and new arch. Specifically when using bundle exec pod install --project-directory=iosfrom the root project directory, it will lead to: I already have a fix, will post the PR link here shortly. |
|
PR is here: react/react-native#33399 |
|
Commit is at react/react-native@2f813f8 |
|
While trying to get react-native-navigation iOS to work with the new arch, I noticed that the |
|
Commit is at react/react-native@75105e6 |
|
macCatalyst builds have not worked since 0.64, it is one of the reasons people don't update per the poll conducted recently. react/react-native#33406 chewing on CI now, has successful testing report already, related flipper repo issue facebook/flipper#3117 but I'm aware Flipper updates are sometimes subtle... |
|
Sad news, apparently the catalyst slice is still not functional. We've proven we can publish new Flipper-DoubleConversion/Flipper-Glog, we've proven we can integrate the new version safely with regard to regression (I think) but we have not fixed the underlying problem yet. I believe I've identified root cause and suggested fix, but this commit is not the one to pick, or at least there will be a follow-on after with new point releases of above-mentioned pod. Pursuing this in facebook/flipper#3117 still |
|
Catalyst builds are not fun, so I'm not surprised people were still having trouble on the related issue after the commit we landed here. However, I have a script that proves (to my satisfaction anyway) that catalyst builds now work +hermes +flipper as long as we have the results of commit 2a5265d integrated and you tweak a few things that just need documenting or doctor checks. Details here facebook/flipper#3117 (comment) @kelset as near as I can tell this one is ready to pick and unblock catalyst folks from upgrading past 0.64 now |
|
We found an issue with the new version of Glog used there, causing random crashes with assertion in mutex, will bump the version once again to address it :) |
|
Guess I should have said "catalyst builds build" not that "they work", Just for future reference for anyone following along, most of my release testing is up to the point of simply verifying it actually builds. That's hard enough at this point! I don't do much real application usage on non-default cases (ios+hermes+flipper / android+hermes+flipper is about it for real app testing from me at the moment) |
|
will do what I can to hide this thread, appears fully resolved. Here's 0.68.0-rc.3 with no flipper versions or patches [edit, I'm unable to hide anything here, but if anyone else can collapse comments --> works for me ]
|
|
from expo side, we really hope this pr to be landed before release: react/react-native#32983, because it's a breaking change to our setup. please let me know if there's anything i can do to help with this. |
|
Fresh init project (0.68-rc2) won't run on Android when new architecture is enabled. |
|
Seems like Windows-related problem, can you try overriding paths in Not sure what Windows-compatible here would be, maybe just replacing cc @cortinico |
|
Overall, it might be related to paths being something like |
|
Yup this looks like a windows-specific setup. We don't have windows machines so the testing surface there is definitely lower. @ShikaSD I believe the problem here is here: Specifically in: This is used to compose the last part of the path of: @Elabar Could you try to edit the externalNativeBuild {
ndkBuild {
arguments "APP_PLATFORM=android-21",
"APP_STL=c++_shared",
"NDK_TOOLCHAIN_VERSION=clang",
+ // Note REACT_NDK_EXPORT_DIR is added here
+ "REACT_NDK_EXPORT_DIR=$buildDir\react-ndk\exported",
+ // Just replace slashes here
+ "GENERATED_SRC_DIR=$buildDir\generated\source",
+ "PROJECT_BUILD_DIR=$buildDir",
+ "REACT_ANDROID_DIR=$rootDir\..\node_modules\react-native\ReactAndroid",
+ "REACT_ANDROID_BUILD_DIR=$rootDir\..\node_modules\react-native\ReactAndroid\build"
- "GENERATED_SRC_DIR=$buildDir/generated/source",
- "PROJECT_BUILD_DIR=$buildDir",
- "REACT_ANDROID_DIR=$rootDir/../node_modules/react-native/ReactAndroid",
- "REACT_ANDROID_BUILD_DIR=$rootDir/../node_modules/react-native/ReactAndroid/build"
}
}Not sure if that's going to work though. We might have to provide win-specific setup inside |
|
I was sure this was handled before so I checked out AOSP seems like a solved problem conceptually but will require some strategy it appears, if even AOSP host host-specific wrappers |
Tried with one "\", reports invalid path. |
and others
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
For >RC3, refer to the follow up discussion here
The branch cut has happened.
Notice
Highlighted Changes in this release
Release Process
Checklist
When ready to publish stable
react-native-websiteto ship new versionRetrospective Topics
Release Status
Tracking 0.68.0-rc.3
Picks for 0.68.0-rc.3 (still waiting for a few to be merged/confirmed)
0.68.0-rc.2
Blocking issues for releasing 0.68.0-rc.2
Picks for 0.68.0-rc.2
0.68.0-rc.1
Picks for 0.68.0-rc.1
All reactions