Improve test suite to fix default Exception message (PHP 8.1)#210
Merged
clue merged 1 commit intoreactphp:masterfrom Feb 7, 2022
Merged
Improve test suite to fix default Exception message (PHP 8.1)#210clue merged 1 commit intoreactphp:masterfrom
clue merged 1 commit intoreactphp:masterfrom
Conversation
PHP8.1+ complains about Exception not accepting `null` as the message argument for an `Exception` constructor. This fixes it.
WyriHaximus
requested review from
WyriHaximus,
clue,
igorw and
jsor
and removed request for
igorw
WyriHaximus
approved these changes
Feb 5, 2022
jsor
approved these changes
Feb 6, 2022
SimonFrings
approved these changes
Feb 7, 2022
clue
changed the title
clue
approved these changes
Feb 7, 2022
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@bzikarsky Thanks for looking into this, changes LGTM! 
Refs #199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP8.1+ complains about Exception not accepting
nullas the message argument for anExceptionconstructor. This fixes it.