Closed
Conversation
clue
requested changes
Oct 6, 2018
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@rabollig Thank you for looking into this, I agree that it makes sense to support this here 👍
Can you add some unit tests to verify the correct record value is parsed from incoming response messages? It's my understanding that this record type should contain structured data, somewhat similar to a SRV record as implemented in #108 for example.
Member
|
I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. Please comment/update if you think this is still relevant and we can reopen this 👍 Thank you for your effort nonetheless, keep it up! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference https://en.wikipedia.org/wiki/List_of_DNS_record_types and
https://en.wikipedia.org/wiki/DNS_Certification_Authority_Authorization