Skip to content

Front End Implementation for the Citation Project#3

Merged
gsviteri merged 23 commits into
masterfrom
private-yusra-citation-project
May 4, 2020
Merged

Front End Implementation for the Citation Project#3
gsviteri merged 23 commits into
masterfrom
private-yusra-citation-project

Conversation

@yusra-haider

@yusra-haider yusra-haider commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

This is the front end / Joomla implementation for the citation project

Link to Back End PR: reactome/content-service#6

The Citation Project adds a Cite Us button to our Joomla website. Clicking on the button opens a modal with the relevant citation according to the page the user is on.

Endpoints in the Content Service repository are being queried for pathway, static, download citations and for exporting these citations

Overall

  • Implement basic modal functionality for fetching and populating citation text in the modal for static citations
  • Implement a basic modal functionality for fetching and populating citation text for the pathways and the downloads page
  • Implement the copy to clipboard and email functionality
  • implement export functionality, with export as BibTex, RIS and Text formats for both static and pathway citations

General UI issues:

  • [] figure out a better way to do downloads, if any. Evaluate different options, according to browser computer, outlined here: https://stackoverflow.com/questions/3665115/how-to-create-a-file-in-memory-for-user-to-download-but-not-through-server/33542499#33542499
  • hide the copy to clipboard and email buttons in case we are unable to fetch data for citation
  • hide / disable the the export section for the downloads page, as that is a special case
  • figure out how to give a line break in the pathway citation
  • [] note the browser compatibility issues that may arise due to using Clipboard.js
  • figure out if we have to use the hasImage field in the pathway citation endpoint for displaying the Image Citation line in Pathway Citations
  • uncheck any selected radio buttons when the modal closes
  • work on the button placement in the website (CSS)
  • work on the CSS for the modal
  • work on making the fact that the export button is disabled unless an export option is chosen more obvious

…mail implemented. The citation text is dynamically generated depending on which page of the website the user is currently on
@gsviteri

gsviteri commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

Why did you create it ?!

Comment thread templates/favourite/index.php Outdated
Comment thread templates/favourite/index.php Outdated
Comment thread templates/favourite/index.php Outdated
Comment thread templates/favourite/index.php Outdated
Comment thread templates/favourite/index.php Outdated
Comment thread templates/favourite/css/custom.css Outdated
1) if the pathway has the doi, the citation will show the doi url
2) else the pathway citation will show the reactome url for the pathway with the stid
- renamed the modal ids so that they aren't generic anymore
- shifted styling on disabled/ enabled export button to css
Comment thread templates/favourite/css/custom.css Outdated

@gsviteri gsviteri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@yusra-haider yusra-haider changed the title [do not merge yet] Front End Implementation for the Citation Project Front End Implementation for the Citation Project Apr 28, 2020
@gsviteri gsviteri merged commit 00e67a7 into master May 4, 2020
@gsviteri gsviteri deleted the private-yusra-citation-project branch December 17, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants