Fix #6487 specify which Sandpack files go into a src directory#6496
Merged
mattcarrollcode merged 2 commits intoreactjs:mainfrom Dec 15, 2023
Merged
Fix #6487 specify which Sandpack files go into a src directory#6496mattcarrollcode merged 2 commits intoreactjs:mainfrom
Sandpack files go into a src directory#6496mattcarrollcode merged 2 commits intoreactjs:mainfrom
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
geeseyj
changed the title
Sandpack files go into a src directory
Contributor
|
@geeseyj Thanks for identifying and writing up a fix! This looks like a lot of monotonous work, thank you for doing this. The general approach looks good I'm taking a closer look now. |
Contributor
Author
|
I just found a few stragglers 😅 🤦 un momento |
mattcarrollcode
approved these changes
Dec 15, 2023
Contributor
mattcarrollcode
left a comment
mattcarrollcode
left a comment
There was a problem hiding this comment.
LGTM! Thanks, merging
Contributor
Author
|
Thanks!
Luckily regexr was able to help me out hah regexr.com/7p78p |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preface: #6487
This PR removes the assumption that all
Sandpackexample files should be put into a/src/folder and instead does so explicitly on only that files that need it.preview