Skip to content

Assume HOC first param is Component not last - #343

Merged
danez merged 1 commit into
masterfrom
hoc
Oct 16, 2019
Merged

Assume HOC first param is Component not last#343
danez merged 1 commit into
masterfrom
hoc

Conversation

@danez

@danez danez commented Apr 13, 2019

Copy link
Copy Markdown
Collaborator

Unless we know for sure it is not a component (literal, array, object, spread)

I did some research too and it seem most HOC have the component as first like for example relay and React.memo.

In case though someone wrote a HOC that assumes the component is the last argument, this will break their documentation.

Fixes #342

Unless we know for sure it is not a component (literal, array, object, spread)
@danez
danez merged commit 2873c8d into master Oct 16, 2019
@danez
danez deleted the hoc branch October 16, 2019 21:57
@Evalon

Evalon commented Oct 24, 2019

Copy link
Copy Markdown

This is great, thank you for your work! Will it be released soon?

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React.memo not wonking

2 participants