This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Copy across the specified properties of each dataset when updating the chart#98
Closed
tomduncalf wants to merge 1 commit intoreactjs:chartjs-v2from
Closed
Copy across the specified properties of each dataset when updating the chart#98tomduncalf wants to merge 1 commit intoreactjs:chartjs-v2from
tomduncalf wants to merge 1 commit intoreactjs:chartjs-v2from
Conversation
…e chart - currently just hidden
tomduncalf
changed the title
Author
|
@austinpray any thoughts on this? |
Author
|
Just seen #109 which looks like a better implementation of this, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that no properties of the datasets are copied across when updating the chart from a
propschange - in my case, trying to show or hide a series with a checkbox.I'm open for discussion on the best way to do this - for now I've just created a whilelist of properties to copy across (with just my use case in it :)) but maybe there is a better way... could the entire
datasetsproperty just be copied across? I wasn't sure what the reasoning behind iterating over it and copying across one by one is.