Use create-react-class to avoid warning#184
Use create-react-class to avoid warning#184austinpray merged 2 commits intoreactjs:chartjs-v2from merlinstardust:chartjs-v2
Conversation
|
When will this fix be merged? |
|
Why not change components to use js classes instead? |
|
@filipebarcos This is a faster fix to get the warning removed. Replacing it with JS classes will require an actual refactor |
|
@merlinpatt thank you for the commit. would love to see this merged, so the warning will be gone. IMHO, in a long-term refactoring perhaps is better. however, in a near-term, eliminating the warning will definitely be beneficial, to me, at least. |
|
Agree that this is the simplest low-risk fix for the short term to help users of the library continue to use it whilst preparing for React 16 |
|
@arjunskumar47 @austinpray can we get this in as a priority? |
|
Hi guys ! Can we get this into the master branch ? So people using React 16 can also use this module ? |
|
Is there another package on npm compatible with this fix? Kinda need it for a react update to v16. |
|
https://github.com/jerairrest/react-chartjs-2 Look for equivalent packages on npms.io ;) |
9 participants
Fixes #183