This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Remove lowercase transform for chart type#116
Open
ghost wants to merge 1 commit intochartjs-v2from
unknown repository
Open
Remove lowercase transform for chart type#116ghost wants to merge 1 commit intochartjs-v2from unknown repository
ghost wants to merge 1 commit intochartjs-v2from
unknown repository
Conversation
Member
|
I asked the guy over on https://github.com/maxkolyanov/react-chartjs/commit/ad46cca5be9db09487b47bb5c520b85cd6a80c35 but yeah if he doesn't respond then yeah probably the toLowerCase. It's not immediately obvious what it is accomplishing. |
Collaborator
|
@maxkolyanov this PR needs to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for horizontal bar chart and some other types of chart that will be added to chart.js in the future.
See: #115