StrictMode translation to spanish#656
Merged
carburo merged 8 commits intoreactjs:mainfrom May 4, 2023
Merged
Conversation
Contributor
Author
|
@carburo Buen día carburo, espero puedas chequear el PR en cualquier momento. Saludos y un gran comienzo de semana 👍🏻. |
Collaborator
mateoguzmana
left a comment
mateoguzmana
left a comment
There was a problem hiding this comment.
Excelente trabajo, se ve muy bien en general. Solo noté unas cosas pequeñas.
Contributor
Author
|
@mateoguzmana Muchas gracias Mateo, ya hice push de los cambios que me pediste 👍🏻 |
mateoguzmana
approved these changes
May 1, 2023
carburo
requested changes
May 2, 2023
Member
carburo
left a comment
carburo
left a comment
There was a problem hiding this comment.
¡Hola, @Dazzae-exe! ¡Muchas gracias por tu contribución! Te he dejado varios comentarios sobre algunos aspectos que deberías revisar antes de poder mezclar este PR.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
carburo
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict Mode
Encantado de corregir algún cambio que se necesite asap.