[Bug]: DynamicData is not AOT Friendly

[dwcullop]

Describe the bug 🐞

Description

When using DynamicData in an WinAppSDK application that is compiled natively with AOT, the trimmer emitted the following warnings:

6>/_/src/DynamicData/Binding/BindingListEventsSuspender.cs(21,17): Trim analysis error IL2091: DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0.<.ctor>b__0(): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'T' of 'DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>/_/src/DynamicData/Binding/BindingListEventsSuspender.cs(22,17): Trim analysis error IL2091: DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0.<.ctor>b__0(): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'T' of 'DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>ILLink : Trim analysis error IL2091: DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0.list: 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'T' of 'DynamicData.Binding.BindingListEventsSuspender<T>.<>c__DisplayClass1_0' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>/_/src/DynamicData/Binding/BindingListEventsSuspender.cs(16,9): Trim analysis error IL2091: DynamicData.Binding.BindingListEventsSuspender<T>.BindingListEventsSuspender`1(BindingList<BindingListEventsSuspender<T>.T>): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'T' of 'DynamicData.Binding.BindingListEventsSuspender<T>' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>/_/src/DynamicData/Binding/BindingListEventsSuspender.cs(14,5): Trim analysis error IL2091: DynamicData.Binding.BindingListEventsSuspender<T>.BindingListEventsSuspender`1(BindingList<BindingListEventsSuspender<T>.T>): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'T' of 'DynamicData.Binding.BindingListEventsSuspender<T>' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>/_/src/DynamicData/Binding/SortAndBind.cs(146,18): Trim analysis error IL2091: DynamicData.Binding.SortAndBind<TObject,TKey>.SortApplicator.Reset(IEnumerable<SortAndBind<TObject,TKey>.SortApplicator.TObject>, Boolean): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'TObject' of 'DynamicData.Binding.SortAndBind<TObject,TKey>.SortApplicator' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
6>/_/src/DynamicData/Binding/SortAndBind.cs(139,13): Trim analysis error IL2091: DynamicData.Binding.SortAndBind<TObject,TKey>.SortApplicator.Reset(IEnumerable<SortAndBind<TObject,TKey>.SortApplicator.TObject>, Boolean): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'System.ComponentModel.BindingList<T>'. The generic parameter 'TObject' of 'DynamicData.Binding.SortAndBind<TObject,TKey>.SortApplicator' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

I believe these can be eliminated by adding the appropriate attributes to help the trimmer figure out what needs to be kept.

Step to reproduce

1. Create a new WinAppSDK application with DynamicData
2. Add these to your project file:

        <IsAotCompatible>true</IsAotCompatible>
        <!-- Show all Trimmer Warnings -->
        <TrimmerSingleWarn>false</TrimmerSingleWarn>

3. Create a release app package
4. You'll observe the above warnings

Reproduction repository

https://github.com/reactivemarbles/DynamicData/

Expected behavior

No trimmer warnings related to DynamicData should be emitted.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

DynamicData Version

9.1.1

Additional information ℹ️

No response

[JakenVeina]

I know very little about AoT, as far as technicals go, but I've got no issue with improving AoT support, wherever there's an opportunity.

[glennawatson]

Mostly just remove as much reflection as you can. Use source generators if able to replace it. Use generic overload versions of reflection api then you'll have to mark the method.

Worst case scenario you can mark that individual method with likely not supported under aot.

There are project csproj settings you can turn on that give you analysers where it's not aot compatible.

[dwcullop]

In this case, all of the warnings I listed were related to use of BindingList<T> which has a type parameter marked with the DynamicallyAccessedMembers attribute. You have to ensure that anything forwarding a type parameter also has the same attributes (all the way up the call chain).

That attribute doesn't exist pre-Net5, so I polyfilled it to avoid a bunch of ugly #if/#endif blocks, and then added it to all the places I found by starting at BindingList and then walking up the call chain until I got to external code.

[dwcullop]

Addressed by #987

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.