Skip to content

[Bug]: GroupOnObservable fires OnComplete if the Source does #937

Description

@dwcullop

Describe the bug 🐞

The GroupOnObservable fires OnComplete as soon as the source fires it, which will prematurely close the stream (sometimes before any groups can actually be made).

Step to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Reproduction repository

https://github.com/reactivemarbles/DynamicData/

Expected behavior

It shouldn't fire OnComplete until the source fires OnComplete and ALL Grouping Observables have fired their OnComplete because grouping changes could come in at any time before then.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

DynamicData Version

9.0.4

Additional information ℹ️

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions