Fix flask backend mimetype for modules#1131
Merged
rmorshea merged 4 commits intoreactive-python:mainfrom Oct 22, 2023
Merged
Conversation
Collaborator
|
I think we can do this, but is this possibly related to this sort of issue? |
Contributor
Author
|
Possibly, but doesn't seem to be exactly the same. |
2e6255c to
552ea13
Compare
Contributor
Author
|
Umm, seems like the lint checks are broken? |
Collaborator
|
No. I'll put up a fix for that shortly. |
Contributor
Author
|
Hey @rmorshea any updates on this issue? |
rmorshea
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request you agree that all contributions to this project are made under the MIT license.
Issues
When running reactpy with Flask backend,
web.module_from_templateresulted an error (in the browser) about wrong mimetype. In example:Solution
Explicitly add the mimetype when using
send_fileChecklist
changelog.rsthas been updated with any significant changes.