Skip to content

Change folder structure based on discussion#66

Merged
orama254 merged 7 commits into
reactdeveloperske:developfrom
orama254:develop
Jun 28, 2022
Merged

Change folder structure based on discussion#66
orama254 merged 7 commits into
reactdeveloperske:developfrom
orama254:develop

Conversation

@orama254
Copy link
Copy Markdown
Member

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 5:28PM (UTC)

Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good 👍 I only found one thing related to the folder structure that we need to adjust: src/pages/api/hello.js should be named src/pages/api/hello.api.js (run the project and visit http://localhost:3000/api/hello, you should see the API response below)

{
  "name": "John Doe"
}

Copy link
Copy Markdown
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@orama254 orama254 merged commit 62e270f into reactdeveloperske:develop Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants