Export Animated.Numeric type in public API#57309
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary: `Numeric` is defined and exported by `AnimatedImplementation` and re-exported as a named export from `Animated`, but it was missing from the `Animated` namespace object assembled in `AnimatedExports`. We have usages of this in fbsource, therefore export on the public API for parity. Changelog: [General][Added] - **Strict TypeScript API**: Export `Animated.Numeric` Differential Revision: D109430487
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109430487. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
|
This pull request has been merged in 6206b0b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Numericis defined and exported byAnimatedImplementationand re-exported as a named export fromAnimated, but it was missing from theAnimatednamespace object assembled inAnimatedExports.We have usages of this in fbsource, therefore export on the public API for parity.
Changelog:
[General][Added] - Strict TypeScript API: Export
Animated.NumericDifferential Revision: D109430487