Skip to content

Try to fix tvOS and podspec builds - #12866

Closed
mkonicek wants to merge 1 commit into
react:masterfrom
mkonicek:jsc_tvos
Closed

mkonicek wants to merge 1 commit into
react:masterfrom
mkonicek:jsc_tvos

Conversation

@mkonicek

@mkonicek mkonicek commented Mar 10, 2017 •

Copy link
Copy Markdown
Contributor

Test plan:

  • Tested locally that UIExplorer compiles for iOS and tvOS targets.
  • Travis tests.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 10, 2017
@mkonicek mkonicek changed the title Try to fix tvOS and podspec builds [DO NOT MERGE BEFORE TRAVIS TESTS PASS] Try to fix tvOS and podspec builds Mar 10, 2017
@mkonicek mkonicek changed the title [DO NOT MERGE BEFORE TRAVIS TESTS PASS] Try to fix tvOS and podspec builds Try to fix tvOS and podspec builds Mar 10, 2017
@mkonicek

Copy link
Copy Markdown
Contributor Author

This fixes tvOS and podspec test. Investigating the e2e failure separately.

@facebook-github-bot shipit-ninja

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Mar 10, 2017
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants