Add PlatformConstants.ServerHost for iOS to support react-devtools on device

[brentvatne]

Description

As described in this issue, react-devtools works great for iOS and Android in simulator/emulator, but only works on device on Android. I believe this is because PlatformConstants.ServerHost is not implemented on iOS, so it always falls back to attempting to connect to localhost, and therefore from your device the react-devtools are unreachable.

Reproduction Steps and Sample Code

Try to run react-devtools and connect with an iOS device

Solution

Add PlatformConstants.ServerHost to RCTPlatform, it should be a string constant that returns the ip:port string that points to the packager. With this change in place, react-devtools should work out of the box on device on iOS.

Additional Information

• React Native version: 0.45
• Platform: iOS
• Development Operating System: macOS

[gaearon]

We’re going to look at this with @javache.

[javache]

In some places we use getDevserverUrl. It sounds like we should merge that with ServerHost, which is only exposed on Android right now.

[nahuelhds]

Any news on this? Would be very nice.

[macrozone]

See also #15547 for a different approach.

[Eyesonly88]

Is anyone working on this? if not I can pick it up and do it.

[brentvatne]

@Eyesonly88 - I don't think so! would love to see a PR for it

[jhen0409]

@Eyesonly88 are you already doing this? If NO, I can change #15547 to support PlatformConstants.ServerHost for iOS.

I missed this issue. 😢

[fiznool]

This or #15547 would be greatly appreciated! I'm teaching a course on React Native and telling students to manually patch the setupDevtools function is proving to be difficult. It seems to me that #15547 is superior to maintaining two pieces of native code too?

[Eyesonly88]

@jhen0409 sorry, I didn't get around to fixing this issue and stopped working on it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

[fiznool]

This should definitely remain open! Without the proposed fixes in this thread, we can't use the remote inspector on an iOS device, which IMHO should absolutely work.

[geirman]

@jhen0409 Looks like you have a fix for this figured out. Would you be able to submit a PR to fix this? https://github.com/facebook/react-native/pull/15547/files