Add Popover z-index token and FormLayoutCustomField label auto-hide#715
Closed
adamkudrna wants to merge 2 commits into
Closed
Add Popover z-index token and FormLayoutCustomField label auto-hide#715adamkudrna wants to merge 2 commits into
Popover z-index token and FormLayoutCustomField label auto-hide#715adamkudrna wants to merge 2 commits into
Conversation
…context
Creates `FormLayoutCustomFieldContext` and has `FormLayoutCustomField` provide
it to its children. `TextField`, `TextArea`, `SelectField`, and
`FileInputField` consume the context to automatically hide their labels when
rendered inside a `FormLayoutCustomField`, making the behavior a hard rule
rather than a recommendation.
Updates the `FormLayout` README to reflect the automatic behavior and removes
all now-redundant `isLabelVisible={false}` from code examples. Removes the
prop from `FormLayoutCustomField` test fixtures and the `FormLayout` story
accordingly.
Also adds per-component `formLayout` test coverage for `labelWidth` and the
new `formLayoutCustomField` visual tests to `TextField`, `TextArea`,
`SelectField`, `FileInputField`, `Button`, `CheckboxField`, `Radio`, and
`Toggle`.
- Add `--rui-Popover__z-index` token (default: `auto`) so consumers can control the Popover's stacking context without needing attribute selectors or class injection. - Allow `visibility` through `cleanPlacementStyle` so callers can hide the Popover before its initial position is computed (flash guard). - Document both additions in README Theming table and placementStyle prop JSDoc.
adamkudrna
force-pushed
the
task/popover-z-index-token
branch
from
June 29, 2026 19:01
743a677 to
f64db2b
Compare
Contributor
|
adamkudrna
had a problem deploying
to
pr-preview/pr-715
June 29, 2026 19:02 — with 
GitHub Actions
Error
GitHub Actions
Error
Member
Author
|
🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--rui-Popover__z-indexCSS custom property (default:auto) so consumers can control stacking context without attribute selectors or class injection; document usage in READMEvisibilitythroughcleanPlacementStyleso callers can hide the Popover before its initial position is computed (flash guard); document in READMEFormLayoutCustomFieldvia context so label visibility is handled automatically by the layoutTest plan
--rui-Popover__z-indexis setvisibility: hiddeninplacementStyleis hidden before position is readyFormLayoutCustomFieldare hidden automatically🤖 Generated with Claude Code