Use Node 22 (current LTS) for development#573
Merged
Conversation
mbohal
approved these changes
Oct 21, 2024
Contributor
|
I would update package.json in such way, that I would remove This is how React does it. RUI does not required any specific version to run, only dev environment does. What do you think @adamkudrna @mbohal ? |
Contributor
|
I agree with using See: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#devengines for usage. I wonder if we should fail or warn on error. I think I would prefer to fail… |
mbohal
self-requested a review
October 22, 2024 11:57
Contributor
|
@mbohal good point. It is weird that library like React have it wrong, but you are right unless there is some undocumented approach. |
adamkudrna
commented
Nov 1, 2024
adamkudrna
commented
Nov 1, 2024
Drop Node 18 for testing builds. Add Node 22.x to dev engines.
adamkudrna
force-pushed
the
maintenance/node-22
branch
from
November 4, 2024 15:23
881078c to
01b1499
Compare
adamkudrna
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.