Fix rendering glitch of Popover arrow on low-dpi displays#559
Merged
Conversation
adamkudrna
reviewed
Aug 26, 2024
adamkudrna
left a comment
Member
There was a problem hiding this comment.
Thank you for the fix! I'd like to ask for a few minor adjustments to improve code readability and keep the existing flexibility (rem units).
Member
|
The PR name could be like "Fix rendering glitch of |
adamkudrna
requested changes
Aug 30, 2024
adamkudrna
left a comment
Member
There was a problem hiding this comment.
OK, this took me some time to figure out, but I think I found the right calculations for what we need. You can test it with various values, for example 2 px gap and 8 px overlap or whatsoever.
Popover arrow on low-dpi displays
adamkudrna
reviewed
Sep 4, 2024
atmelmicro
force-pushed
the
bug/popover-line
branch
2 times, most recently
from
September 12, 2024 12:54
33a9195 to
ed04de4
Compare
Contributor
Author
Contributor
atmelmicro
force-pushed
the
bug/popover-line
branch
from
September 13, 2024 10:22
ed04de4 to
e1bb6cc
Compare
atmelmicro
requested review from
bedrich-schindler and
mbohal
as code owners
September 13, 2024 10:22
mbohal
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Because of rendering quirks sometimes a line can appear between the popover and arrow

(more visible on low dpi displays)
This pr fixes that by moving the arrow 1px down
