feat: improve the npm/yarn installation instruction#693
Merged
Conversation
satya164
requested changes
Feb 26, 2020
Member
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
Thanks for the PR.
--save is not necessary when running npm as it adds the dependency to package.json like yarn for a while now. Can you remove the addition of --save?
Member
Author
Yes, done :) |
Member
|
FYE we may add this plugin to docusaurus repo: facebook/docusaurus#3469 |
Member
Author
|
will be amazing @slorber, because right now we're using a copy/paste code from docusaurus core. I just subscribed for this plugin PR and definitely, I want to import that from docusaurus when is available to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: